You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/01 11:26:52 UTC
[GitHub] [pulsar] racorn opened a new pull request #8177: Improve refactored client connection code (previous PR #8117).
racorn opened a new pull request #8177:
URL: https://github.com/apache/pulsar/pull/8177
### Motivation
Improve previous PR #8117 (Always use SNI for TLS enabled Java client)
### Modifications
- Use `ChannelFutures.toCompletableFuture` instead of private static utility method.
- When TLS is not enabled, use 'original' code that invokes `Bootstrap.connect(InetSocketAddress)`; it is only when TLS is enabled we need custom setup code to properly set SNI headers.
- Add documentation and argument checks to `PulsarChannelInitializer.initTls`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8177: Improve refactored client connection code (previous PR #8117).
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8177:
URL: https://github.com/apache/pulsar/pull/8177#issuecomment-702072947
If this update (and preceding #8177 and #8062 ) could be added to an upcoming release, it would be much appreciated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn edited a comment on pull request #8177: Improve refactored client connection code (previous PR #8117).
Posted by GitBox <gi...@apache.org>.
racorn edited a comment on pull request #8177:
URL: https://github.com/apache/pulsar/pull/8177#issuecomment-702072947
If this update (and preceding #8177 and #8062 ) could be added to an upcoming release, it would be much appreciated. [#8062 is arguable a bug fix]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] racorn commented on pull request #8177: Improve refactored client connection code (previous PR #8117).
Posted by GitBox <gi...@apache.org>.
racorn commented on pull request #8177:
URL: https://github.com/apache/pulsar/pull/8177#issuecomment-702104107
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8177: Improve refactored client connection code (previous PR #8117).
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8177:
URL: https://github.com/apache/pulsar/pull/8177
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org