[GitHub] [beam] damccorm commented on a diff in pull request #26010: [Tour of Beam] Save code, Delete account & other tasks

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on code in PR #26010:
URL: https://github.com/apache/beam/pull/26010#discussion_r1173917697


##########
learning/tour-of-beam/frontend/lib/auth/notifier.dart:
##########
@@ -21,9 +21,16 @@ import 'dart:async';
 import 'package:firebase_auth/firebase_auth.dart';
 import 'package:firebase_auth_platform_interface/firebase_auth_platform_interface.dart';
 import 'package:flutter/material.dart';
+import 'package:get_it/get_it.dart';
+import 'package:playground_components/playground_components.dart';
+
+import '../cache/unit_progress.dart';
+import '../repositories/client/client.dart';
 
 class AuthNotifier extends ChangeNotifier {
-  AuthNotifier() {
+  final TobClient client;
+
+  AuthNotifier({required this.client}) {

Review Comment:
   Are we using this? If not, why are we passing it in?



##########
learning/tour-of-beam/frontend/lib/config.dart:
##########
@@ -18,8 +18,20 @@
 
 // TODO(alexeyinkin): Generate this file on deployment.
 
-const _cloudFunctionsProjectRegion = 'us-central1';
-const _cloudFunctionsProjectId = 'tour-of-beam-2';
+const _cloudFunctionsProjectRegion = 'us-east1';
+const _cloudFunctionsProjectId = 'river-key-378010';
 const cloudFunctionsBaseUrl = 'https://'
     '$_cloudFunctionsProjectRegion-$_cloudFunctionsProjectId'
     '.cloudfunctions.net';
+
+// Copied from Playground's config.g.dart

Review Comment:
   Do these need to stay in sync? If so, could we drop a comment in the original file saying they should stay in sync (and update this comment)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org