You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2026/03/03 14:54:23 UTC
[PR] ci: Use rust 2024 edition's default resolver instead [arrow-rs]
Xuanwo opened a new pull request, #9502:
URL: https://github.com/apache/arrow-rs/pull/9502
# Which issue does this PR close?
- Closes https://github.com/apache/arrow-rs/pull/9501.
# Rationale for this change
We previously used `resolver=2` to enable feature unification. This functionality is now covered by the new `resolver=3`. Additionally, `resolver=3` is the default for the Rust 2024 edition and includes the valuable feature of MSRV-aware dependency resolution.
I just remove our old `resolver=2` pin so we can use the edition's default.
# What changes are included in this PR?
cargo's resolver
# Are these changes tested?
In CI
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: Use rust 2024 edition's default resolver instead [arrow-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #9502: ci: Use rust 2024 edition's default resolver instead
URL: https://github.com/apache/arrow-rs/pull/9502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: Use rust 2024 edition's default resolver instead [arrow-rs]
Posted by "scovich (via GitHub)" <gi...@apache.org>.
scovich commented on PR #9502:
URL: https://github.com/apache/arrow-rs/pull/9502#issuecomment-3994834715
I don't think the newfangled resolver worked? The [MSRV job](https://github.com/apache/arrow-rs/actions/runs/22628686064/job/65572300549?pr=9502) fails -- really ugly formatting?? -- with:
```
Checking comfy-table v7.2.2\nerror[E0658]: `let` expressions in this position are unstable\n --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/comfy-table-7.2.2/src/utils/arrangement/disabled.rs:21:12\n |\n21 | if let Some(max_width) = constraint::max(table, &column.constraint, visible_columns)\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n |\n = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information\n\nerror[E0658]: `let` expressions in this position are unstable\n --> /usr/local/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/comfy-table-7.2.2/src/utils/formatting/content_format.rs:101:12\n |\n101 | if let Some(lines) = row.max_height\n | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n |\n = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information\n\n Checking hyper-util v0.1.20\nFor more inform
ation about this error, try `rustc --explain E0658`.\nerror: could not compile `comfy-table` (lib) due to 2 previous errors
```
Either that, or comfy-table-7.2.2 lies about its MSRV?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: Use rust 2024 edition's default resolver instead [arrow-rs]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9502:
URL: https://github.com/apache/arrow-rs/pull/9502#issuecomment-4785345665
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org