[GitHub] nandakumar131 commented on a change in pull request #511: HDDS-1148. After allocating container, we are not adding to container DB.

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #511: HDDS-1148. After allocating container, we are not adding to container DB.
URL: https://github.com/apache/hadoop/pull/511#discussion_r259096027
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/SCMContainerManager.java
 ##########
 @@ -215,23 +222,11 @@ public ContainerInfo allocateContainer(final ReplicationType type,
       throws IOException {
     lock.lock();
     try {
-      final ContainerInfo containerInfo; containerInfo = containerStateManager
+      final ContainerInfo containerInfo;
 
 Review comment:
   Can be put as single statement --> 
   final ContainerInfo containerInfo = containerStateManager.allocateContainer(pipelineManager, type, replicationFactor, owner);

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org