You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/01/26 10:13:56 UTC

[GitHub] [james-project] Arsnael opened a new pull request #867: Jwt-revoker container update for oidc example

Arsnael opened a new pull request #867:
URL: https://github.com/apache/james-project/pull/867


   The rpc client from Krakend don't seem to really handle reconnections. It makes more sense as well to open a connection and close it when we finish using it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael commented on pull request #867: Jwt-revoker container update for oidc example

Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #867:
URL: https://github.com/apache/james-project/pull/867#issuecomment-1023061285


   Ideal would be to have one persistent connection between jwt-revoker and krakend for resources and performances concerns. But that would imply a considerable effort to implement necessary things like a pool of connections, connection loss detection, retry mechanisms, ... in golang
   
   Because logout is considered not happening often, it's totally acceptable for now to only create a connection when adding a token to krakend and then closing it down (which is what the above PR proposes).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael commented on pull request #867: Jwt-revoker container update for oidc example

Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #867:
URL: https://github.com/apache/james-project/pull/867#issuecomment-1022783426


   > So, for every request we do open a new connection, right?
   > 
   > Performance wise, this do not look wise! This might be acceptable as "logouts" are expected to be rare, but I would prefer us to just renew connections if they are broken, not all the time.
   
   Honesly the krakend rpc client looks very simple to me, without such mechanisms... but yeah I will try to check... That might imply connection detection, retries, etc... and I'm not proficient in golang just saying


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael merged pull request #867: Jwt-revoker container update for oidc example

Posted by GitBox <gi...@apache.org>.
Arsnael merged pull request #867:
URL: https://github.com/apache/james-project/pull/867


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on pull request #867: Jwt-revoker container update for oidc example

Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #867:
URL: https://github.com/apache/james-project/pull/867#issuecomment-1022107797


   So, for every request we do open a new connection, right?
   
   Performance wise, this do not look wise! This might be acceptable as "logouts" are expected to be rare, but I would prefer us to just renew connections if they are broken, not all the time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org