[jira] [Commented] (IMPALA-11365) Dereferencing null pointer in TopNNode

["Daniel Becker (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555125#comment-17555125 ] 

Daniel Becker commented on IMPALA-11365:
----------------------------------------

https://gerrit.cloudera.org/#/c/18629/

> Dereferencing null pointer in TopNNode
> --------------------------------------
>
>                 Key: IMPALA-11365
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11365
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Daniel Becker
>            Assignee: Daniel Becker
>            Priority: Major
>
> In the constructor of TopNNode, if {{pnode.partition_comparator_config_}} is NULL, we initialise {{partition_cmp_}} with a NULL pointer. However, when initialising {{{}partition_heaps_{}}}, we dereference {{partition_cmp_}} because {{ComparatorWrapper}} expects a reference.
> This has so far not lead to a crash because in this case the comparator of {{partition_heaps_}} is not used, but assigning a NULL pointer to a reference is undefined behaviour.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org