[jira] [Closed] (DAFFODIL-2626) Circular deadlock when computing stored length around prefixed-length elements

["Dave Thompson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DAFFODIL-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2626.
-----------------------------------

Verified the specified commit (commit 9043425760dae277eff36087a2e715c70793db9c) is included in the latest pull from the daffodil repository.

Verified changes identified in commit comments were implemented.

Verified test added for this issue and commented out in previous commits (d6e0c39fe036f278f8e7ad53d7a54dab4041fc92 and 54ee07216996c80e74749db46200273d48da948b) are now uncommented and execute without causing a deadlock.

Verified affected daffodil subproject sbt test suites execute successfully including the additional/uncommented tests.

Verified the nightly test schemas compile and save successfully.

Verified the nightly test suite executes successfully.

> Circular deadlock when computing stored length around prefixed-length elements
> ------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-2626
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2626
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Back End
>    Affects Versions: 3.2.1
>            Reporter: Mike Beckerle
>            Assignee: Steve Lawrence
>            Priority: Critical
>             Fix For: 3.3.0
>
>
> I have a small schema with a messageLength element as the first element, which has outputValueCalc on the message payload.
> The message payload contains prefixed-length strings.
> I get a deadlock on unparsing:
> {code}
> org.apache.daffodil.tdml.TDMLExceptionImpl: (Implementation: daffodil) SuspensionDeadlockException: Runtime Schema Definition Error: Expressions/Unparsers are circularly deadlocked (mutually defined):
>  - SimpleTypeRetryUnparserSuspendableOperation for messageLength
>  - ElementUnusedUnparserSuspendableOperation for payload
>  - AlignmentFillUnparserSuspendableOperation for address
> Schema context: messageLength Location line 59 column 18 in file:/tmp/s__3044777217024912267.dfdl.xsd
> Data location was preceding byte 0
> {code}
> See test test_computedLengthAroundPrefixedLengths1u
> Test test_computedLengthAroundPrefixedLengths1p is the same thing, just testing the parse direction.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)