You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/03/13 14:52:21 UTC
[Bug 57701] New: Implement "[Redeploy]" button for a web application
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Bug ID: 57701
Summary: Implement "[Redeploy]" button for a web application
Product: Tomcat 8
Version: 8.0.20
Hardware: PC
Status: NEW
Severity: enhancement
Priority: P2
Component: Manager
Assignee: dev@tomcat.apache.org
Reporter: knst.kolinko@gmail.com
In Tomcat manager HTML interface for each web application (except the Manager
app itself) there is a "Reload" button. I think that it would be nice to add a
"Redeploy" button there, that will allow to trigger a redeployment of a web
application.
Currently if the server is configured with autoDeploy="true", the redeployment
can be triggered by touching the context file of the application (or the global
conf/context.xml file if the application does not have one and does not have a
war file). If autoDeploy="false" you are out of this option.
I expect the behaviour of this feature to be effectively the same as the one
caused by touching the context file. I would like this to be available in
Tomcat 7.
Documentation:
http://tomcat.apache.org/tomcat-7.0-doc/config/automatic-deployment.html#Modified_files
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Fernando Boaglio <bo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #2 from Fernando Boaglio <bo...@gmail.com> ---
Patch to provide "redeploy" button on Tomcat Web Application Manager.
I hope you like it =)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Dylan Lexie <di...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #34076|0 |1
is obsolete| |
--- Comment #6 from Dylan Lexie <di...@gmail.com> ---
Created attachment 34079
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34079&action=edit
Patch to provide "redeploy" functionality in Tomcat Manager (Amended)
Apologies, the patch I previously uploaded was generated with the new source
file for RedeployTask not added. This amendment fixes that. See above for other
notes.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|---- |-----
Component|Manager |Catalina
Version|8.0.20 |unspecified
Product|Tomcat 8 |Tomcat 9
--- Comment #7 from Mark Thomas <ma...@apache.org> ---
Tomcat 8 has reached End Of Life. Moving this bug to Tomcat 9.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Dylan Lexie <di...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #32741|0 |1
is obsolete| |
CC| |dilexie@gmail.com
--- Comment #5 from Dylan Lexie <di...@gmail.com> ---
Created attachment 34076
--> https://bz.apache.org/bugzilla/attachment.cgi?id=34076&action=edit
Patch to provide "redeploy" functionality in Tomcat Manager
This patch is based on the work of Fernando Boaglio but addresses the issues
raised by Mark Thomas. Removing the context from the host (as in,
host.removeChild) was not sufficient, as the logic invoked by check() deals
with protected/private members of a hostConfig. To complete this functionality,
I saw no better option than to expose a public version of HostConfig.undeploy.
In addition to redeploy support in the HTML manager, this patch adds the
redeploy command to the text manager and a redeploy ant task for the ant-based
text manager wrapper. Maintaining consistency between these closely related
utilities seems to be a more coherent update than just literally fulfilling the
feature request.
Since the issue parameters state Tomcat 8.0, I worked from 8.0.x trunk.
However, I share the OP's wish to see this feature in Tomcat 7. Is there a
"right" way to try to facilitate this? For instance, would it be at all
appropriate to re-mark the issue pertinent to 7 and instead provide a patch
(which might be identical) for that version?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Christopher Schultz <ch...@christopherschultz.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
--- Comment #3 from Mark Thomas <ma...@apache.org> ---
I'm not convinced of the need for this feature but I don't object to it being
added.
Overall the patch looks good. There is the odd s/reload/redploy/ required but
that looks like copy/paste errors and is easily fixed.
I'm more concerned that the actual redeploy code is not correct. The issues I
could see from a code inspection (I haven't tried applying the patch) are:
- it assumes that the web application is deployed as a WAR
- it assumes autoDeployment is enabled
- it doesn't mark the web application as being serviced
I'd expect to see the following:
- the context marked as serviced
- the context removed from the host
- check() being used to redeploy it
- the serviced mark removed from the host
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
--- Comment #4 from Bruno P. Kinoshita <ki...@apache.org> ---
>I'm not convinced of the need for this feature but I don't object to it being added.
I used to see some Spring applications keeping objects in memory, and sometimes
I had to restart Tomcat or redeploy the application. It was some years ago, and
I don't have any Spring application in a Tomcat server (running mostly REST
apps with Jersey), but maybe it would be a valid use case for this patch? Just
my 0.02 cents
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Fernando Boaglio <bo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |boaglio@gmail.com
--- Comment #1 from Fernando Boaglio <bo...@gmail.com> ---
Created attachment 32741
--> https://bz.apache.org/bugzilla/attachment.cgi?id=32741&action=edit
Patch to provide "redeploy" button on Tomcat Web Application Manager.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 57701] Implement "[Redeploy]" button for a web application
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57701
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Catalina |Manager
--- Comment #8 from Mark Thomas <ma...@apache.org> ---
Correct component after move to Tomcat 9.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org