You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2016/02/02 02:37:46 UTC
Review Request 43080: Fixing duplicate instances in the UI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43080/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1604
https://issues.apache.org/jira/browse/AURORA-1604
Repository: aurora
Description
-------
Also, dropped TaskQuery.owner field as all supporting filtering logic for it is long gone.
Diffs
-----
NEWS ef1e75f7ec467ef3a5a33c6dee5b6ef5743c11f7
api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ae05cd4b2f39b9c0450d77ebd16a18664c310ecb
src/main/resources/scheduler/assets/js/services.js 1a76a3f1149c69e7a8f34261df2d955ae240eb6c
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b0451b77bb82f58200b6048c8540bcc76f76b14
Diff: https://reviews.apache.org/r/43080/diff/
Testing
-------
e2e tests and manual testing in vagrant
Thanks,
Maxim Khutornenko
Re: Review Request 43080: Fixing duplicate instances in the UI.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43080/#review117338
-----------------------------------------------------------
Ship it!
Thanks!
- Bill Farner
On Feb. 1, 2016, 5:37 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43080/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 5:37 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1604
> https://issues.apache.org/jira/browse/AURORA-1604
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, dropped TaskQuery.owner field as all supporting filtering logic for it is long gone.
>
>
> Diffs
> -----
>
> NEWS ef1e75f7ec467ef3a5a33c6dee5b6ef5743c11f7
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ae05cd4b2f39b9c0450d77ebd16a18664c310ecb
> src/main/resources/scheduler/assets/js/services.js 1a76a3f1149c69e7a8f34261df2d955ae240eb6c
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b0451b77bb82f58200b6048c8540bcc76f76b14
>
> Diff: https://reviews.apache.org/r/43080/diff/
>
>
> Testing
> -------
>
> e2e tests and manual testing in vagrant
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 43080: Fixing duplicate instances in the UI.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43080/#review117337
-----------------------------------------------------------
Ship it!
Master (824e396) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2016, 1:37 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43080/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 1:37 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1604
> https://issues.apache.org/jira/browse/AURORA-1604
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also, dropped TaskQuery.owner field as all supporting filtering logic for it is long gone.
>
>
> Diffs
> -----
>
> NEWS ef1e75f7ec467ef3a5a33c6dee5b6ef5743c11f7
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ae05cd4b2f39b9c0450d77ebd16a18664c310ecb
> src/main/resources/scheduler/assets/js/services.js 1a76a3f1149c69e7a8f34261df2d955ae240eb6c
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 2b0451b77bb82f58200b6048c8540bcc76f76b14
>
> Diff: https://reviews.apache.org/r/43080/diff/
>
>
> Testing
> -------
>
> e2e tests and manual testing in vagrant
>
>
> Thanks,
>
> Maxim Khutornenko
>
>