You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/04 19:47:01 UTC

[GitHub] [commons-collections] Claudenw commented on a diff in pull request #335: [Collections-834][bloom filters] bit count producer operation is not clearly defined

Claudenw commented on code in PR #335:
URL: https://github.com/apache/commons-collections/pull/335#discussion_r1014415306


##########
src/test/java/org/apache/commons/collections4/bloomfilter/DefaultIndexProducerTest.java:
##########
@@ -47,8 +52,7 @@ public boolean forEachIndex(IntPredicate predicate) {
 
     @Override
     protected int getBehaviour() {
-        // The default method streams a BitSet so is distinct and ordered.

Review Comment:
   Corrected.  I also added `DefaultBitCountProducerTest` and removed duplicate test `UniqueIndexProducerFromHashCollectionTest` which was effectively a duplicate of `BitCountProducerFromUniqueHasherCollectionTest`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org