You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2025/09/25 11:49:14 UTC
[PR] add separate VP component to update VP id and links [cloudstack-www]
DaanHoogland opened a new pull request, #370:
URL: https://github.com/apache/cloudstack-www/pull/370
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add separate VP component to update VP id and links [cloudstack-www]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #370:
URL: https://github.com/apache/cloudstack-www/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add separate VP component to update VP id and links [cloudstack-www]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #370:
URL: https://github.com/apache/cloudstack-www/pull/370#issuecomment-3337059890
will enter some description @jbampton ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add separate VP component to update VP id and links [cloudstack-www]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #370:
URL: https://github.com/apache/cloudstack-www/pull/370#discussion_r2382125618
##########
source/generate_who.py:
##########
@@ -95,10 +95,13 @@ def generate_markdown(pmc_members, committers):
Board Minutes: https://whimsy.apache.org/board/minutes/CloudStack.html
-""")
+````mdx-code-block
+import Releases from "@site/src/components/VP";
Review Comment:
The import statement is incorrect. It should be `import VP from \"@site/src/components/VP\";` to match the component name and usage on line 101.
```suggestion
import VP from "@site/src/components/VP";
```
##########
src/components/VP/index.tsx:
##########
@@ -0,0 +1,47 @@
+import React from "react";
+
+const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report
+ quarterly to the Apache Software Foundation Board,
+ representing CloudStack and providing updates on the health
+ and status of the project. I am grateful for the opportunity
+ to serve as the CloudStack VP and to work with amazing people
+ from the community to continue making CloudStack an even
+ greater cloud orchestration platform!"`
+
+const pmc_chair_name = "Nicolás Vázquez"
+const pmc_chair_picture = "/img/authors/nicolas.png"
+const pmc_chair_githandle = "nvazquez"
+const pmc_chair_linked = "nvazquezuy"
+
+const git_link = "https://github.com/"+pmc_chair_githandle
+const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked
+
+export default function VP(): JSX.Element {
+ return <>
+ <div className="row">
+ <div className="col col--3">
+
+<img src={pmc_chair_picture} alt="{pmc_chair_name}" class="blog-image"/>
Review Comment:
The alt attribute contains literal braces instead of the variable value. It should be `alt={pmc_chair_name}` to properly interpolate the variable.
```suggestion
<img src={pmc_chair_picture} alt={pmc_chair_name} class="blog-image"/>
```
##########
src/components/VP/index.tsx:
##########
@@ -0,0 +1,47 @@
+import React from "react";
+
+const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report
+ quarterly to the Apache Software Foundation Board,
+ representing CloudStack and providing updates on the health
+ and status of the project. I am grateful for the opportunity
+ to serve as the CloudStack VP and to work with amazing people
+ from the community to continue making CloudStack an even
+ greater cloud orchestration platform!"`
+
+const pmc_chair_name = "Nicolás Vázquez"
+const pmc_chair_picture = "/img/authors/nicolas.png"
+const pmc_chair_githandle = "nvazquez"
+const pmc_chair_linked = "nvazquezuy"
+
+const git_link = "https://github.com/"+pmc_chair_githandle
+const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked
+
+export default function VP(): JSX.Element {
+ return <>
+ <div className="row">
+ <div className="col col--3">
+
+<img src={pmc_chair_picture} alt="{pmc_chair_name}" class="blog-image"/>
Review Comment:
In React/JSX, HTML attributes should use camelCase. Change `class` to `className` for proper React syntax.
```suggestion
<img src={pmc_chair_picture} alt="{pmc_chair_name}" className="blog-image"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add separate VP component to update VP id and links [cloudstack-www]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #370: add separate VP component to update VP id and links
URL: https://github.com/apache/cloudstack-www/pull/370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] add separate VP component to update VP id and links [cloudstack-www]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #370:
URL: https://github.com/apache/cloudstack-www/pull/370#discussion_r2382252864
##########
src/components/VP/index.tsx:
##########
@@ -0,0 +1,48 @@
+import React from "react";
+
+const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report
+ quarterly to the Apache Software Foundation Board,
+ representing CloudStack and providing updates on the health
+ and status of the project. I am grateful for the opportunity
+ to serve as the CloudStack VP and to work with amazing people
+ from the community to continue making CloudStack an even
+ greater cloud orchestration platform!"`
+
+const pmc_chair_name = "Nicolás Vázquez"
+const pmc_chair_picture = "/img/authors/nicolas.png"
+const pmc_chair_githandle = "nvazquez"
+const pmc_chair_linked = "nvazquezuy"
+
+const git_link = "https://github.com/"+pmc_chair_githandle
+const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked
+
+export default function VP(): JSX.Element {
+ return <>
+ <div className="row">
+ <div className="col col--3">
+
+<img src={pmc_chair_picture} alt={pmc_chair_name} className="blog-image"/>
+
+ </div>
+ <div className="col col--9">
+
+ <p>
+ <b>
+ PMC Chair</b>: {pmc_chair_name}
+ <a href={git_link} target="_blank">
+ <img src="/img/git_logo.svg" width="40px" alt=""/>
Review Comment:
```suggestion
<img src="/img/git_logo.svg" width="30px" alt=""/>
```
##########
src/components/VP/index.tsx:
##########
@@ -0,0 +1,48 @@
+import React from "react";
+
+const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report
+ quarterly to the Apache Software Foundation Board,
+ representing CloudStack and providing updates on the health
+ and status of the project. I am grateful for the opportunity
+ to serve as the CloudStack VP and to work with amazing people
+ from the community to continue making CloudStack an even
+ greater cloud orchestration platform!"`
+
+const pmc_chair_name = "Nicolás Vázquez"
+const pmc_chair_picture = "/img/authors/nicolas.png"
+const pmc_chair_githandle = "nvazquez"
+const pmc_chair_linked = "nvazquezuy"
+
+const git_link = "https://github.com/"+pmc_chair_githandle
+const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked
+
+export default function VP(): JSX.Element {
+ return <>
+ <div className="row">
+ <div className="col col--3">
+
+<img src={pmc_chair_picture} alt={pmc_chair_name} className="blog-image"/>
+
+ </div>
+ <div className="col col--9">
+
+ <p>
+ <b>
+ PMC Chair</b>: {pmc_chair_name}
Review Comment:
```suggestion
PMC Chair</b>: {pmc_chair_name}
```
##########
src/components/VP/index.tsx:
##########
@@ -0,0 +1,48 @@
+import React from "react";
+
+const pmc_chair_quote = `"Earlier this year, I was selected by my fellow PMC members as the project’s VP. The main role of the VP is to report
+ quarterly to the Apache Software Foundation Board,
+ representing CloudStack and providing updates on the health
+ and status of the project. I am grateful for the opportunity
+ to serve as the CloudStack VP and to work with amazing people
+ from the community to continue making CloudStack an even
+ greater cloud orchestration platform!"`
+
+const pmc_chair_name = "Nicolás Vázquez"
+const pmc_chair_picture = "/img/authors/nicolas.png"
+const pmc_chair_githandle = "nvazquez"
+const pmc_chair_linked = "nvazquezuy"
+
+const git_link = "https://github.com/"+pmc_chair_githandle
+const linked_link = "https://www.linkedin.com/in/"+pmc_chair_linked
+
+export default function VP(): JSX.Element {
+ return <>
+ <div className="row">
+ <div className="col col--3">
+
+<img src={pmc_chair_picture} alt={pmc_chair_name} className="blog-image"/>
+
+ </div>
+ <div className="col col--9">
+
+ <p>
+ <b>
+ PMC Chair</b>: {pmc_chair_name}
+ <a href={git_link} target="_blank">
+ <img src="/img/git_logo.svg" width="40px" alt=""/>
+ </a>
+
+ <a href={linked_link} target="_blank">
+ <img src="/img/social/LinkedIn-Blue.png" width="40px" alt=""/>
Review Comment:
```suggestion
<img src="/img/social/LinkedIn-Blue.png" width="30px" alt=""/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org