You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nervoussidd (via GitHub)" <gi...@apache.org> on 2023/03/22 12:08:50 UTC
[GitHub] [beam] nervoussidd opened a new pull request, #25926: Issue#24903
nervoussidd opened a new pull request, #25926:
URL: https://github.com/apache/beam/pull/25926
This is the script that train the housing data and saves the trained models to GCS i don't have an GCS account so i have just put in the code that will save the model to GCS location.This is not the exact code as i also need to build pipeline but it does reflect the operation what it will do.In the moment just want feedback on the code which will help me to fix the issue.
issue#24903 desc : https://github.com/apache/beam/issues/24903
------------------------
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nervoussidd commented on pull request #25926: Issue#24903
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd commented on PR #25926:
URL: https://github.com/apache/beam/pull/25926#issuecomment-1486343516
I have some doubt regarding adding instruction ,that i need to add the instruction in Readme file?And,I think that i should close this pull request and open a new one after adding this file code to the respective location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25926: Issue#24903
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #25926:
URL: https://github.com/apache/beam/pull/25926#issuecomment-1485737279
Please include your changes of the `sklearn` script here https://github.com/apache/beam/tree/master/sdks/python/apache_beam/testing/benchmarks/inference not at the root beam folder.
Also, include the license for the RAT precommit to pass
```
#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nervoussidd closed pull request #25926: Issue#24903
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd closed pull request #25926: Issue#24903
URL: https://github.com/apache/beam/pull/25926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nervoussidd commented on pull request #25926: Issue#24903
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd commented on PR #25926:
URL: https://github.com/apache/beam/pull/25926#issuecomment-1486978146
Ok then lets continue with 26102...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #25926: Issue#24903
Posted by "AnandInguva (via GitHub)" <gi...@apache.org>.
AnandInguva commented on PR #25926:
URL: https://github.com/apache/beam/pull/25926#issuecomment-1486974624
> #26012 This is the new pull request where i have proposed merge of new file.Should i close this pull request ?
you can either this PR or we can continue discussion on a the pr #26012. Up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nervoussidd commented on a diff in pull request #25926: Issue#24903
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd commented on code in PR #25926:
URL: https://github.com/apache/beam/pull/25926#discussion_r1150041496
##########
script_sklearn_model:
##########
@@ -0,0 +1,48 @@
+import pickle
+import pandas as pd
+from sklearn.linear_model import LinearRegression
+#from google.cloud import storage
+
+"""
Review Comment:
here i have added the code to save the trained models to GCS .If you want to use it just remove the inverted comma and it will be there to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nervoussidd commented on pull request #25926: Issue#24903
Posted by "nervoussidd (via GitHub)" <gi...@apache.org>.
nervoussidd commented on PR #25926:
URL: https://github.com/apache/beam/pull/25926#issuecomment-1486970793
https://github.com/apache/beam/pull/26012
This is the new pull request where i have proposed merge of new file.Should i close this pull request ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org