You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/03 02:21:06 UTC

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18310: [fix][test]fix flaky test MLPendingAckStoreTest.testMainProcess

poorbarcode commented on code in PR #18310:
URL: https://github.com/apache/pulsar/pull/18310#discussion_r1012444146


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/pendingack/impl/MLPendingAckStoreTest.java:
##########
@@ -256,8 +256,28 @@ public Object answer(InvocationOnMock invocation) throws Throwable {
         Assert.assertTrue(mlPendingAckStoreForRead.pendingAckLogIndex.keySet().iterator().next().getEntryId() > 19);
 
         // cleanup.
-        mlPendingAckStoreForWrite.closeAsync().get();
-        mlPendingAckStoreForRead.closeAsync().get();
+        closePendingAckStoreWithRetry(mlPendingAckStoreForWrite, 3);
+        closePendingAckStoreWithRetry(mlPendingAckStoreForRead, 3);

Review Comment:
   Good idea, already fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org