You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/21 20:12:00 UTC
[jira] [Commented] (MINIFICPP-440) Build & statically link libressl
when not available in system
[ https://issues.apache.org/jira/browse/MINIFICPP-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408502#comment-16408502 ]
ASF GitHub Bot commented on MINIFICPP-440:
------------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/289
MINIFICPP-440 Added LibreSSL as an external project build, statically…
…-linked for cases when it isn't available in the target environment for dynamic linking
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-440
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #289
----
commit b068d916234984d6048fb6514c8d6139be8ac04e
Author: Andrew I. Christianson <an...@...>
Date: 2018-03-20T22:19:30Z
MINIFICPP-440 Added LibreSSL as an external project build, statically-linked for cases when it isn't available in the target environment for dynamic linking
----
> Build & statically link libressl when not available in system
> -------------------------------------------------------------
>
> Key: MINIFICPP-440
> URL: https://issues.apache.org/jira/browse/MINIFICPP-440
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Andrew Christianson
> Assignee: Andrew Christianson
> Priority: Major
>
> In order to target systems where no SSL library is available, we should support building & statically linking LibreSSL. This will help make MiNiFi - C++ more portable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)