You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andy Grove (Jira)" <ji...@apache.org> on 2020/12/28 20:55:00 UTC

[jira] [Comment Edited] (ARROW-11030) [Rust] [DataFusion] TPC-H q12 does not finish with SF=100 Parquet input and small batch size

    [ https://issues.apache.org/jira/browse/ARROW-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255723#comment-17255723 ] 

Andy Grove edited comment on ARROW-11030 at 12/28/20, 8:54 PM:
---------------------------------------------------------------

Batch size 131072:
{code:java}
[2020-12-28T20:46:28Z DEBUG datafusion::physical_plan::hash_join] Built build-side of hash join containing 3115341 rows in 9926 ms
[2020-12-28T20:46:36Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 388922 rows in 7994 ms
[2020-12-28T20:46:36Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389294 rows in 7986 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389558 rows in 8326 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 388841 rows in 8499 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 390056 rows in 8643 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18749999 rows and produced 144 output batches containing 389143 rows in 8711 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389605 rows in 8712 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389922 rows in 8877 ms
+------------+-----------------+----------------+
| l_shipmode | high_line_count | low_line_count |
+------------+-----------------+----------------+
| MAIL       | 623115          | 934713         |
| SHIP       | 622979          | 934534         |
+------------+-----------------+----------------+
Query 12 iteration 0 took 19559.0 ms
 {code}
Batch size 32768:
{code:java}
 [2020-12-28T20:51:47Z DEBUG datafusion::physical_plan::hash_join] Built build-side of hash join containing 3115341 rows in 9442 ms
[2020-12-28T20:52:33Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 390056 rows in 45356 ms
[2020-12-28T20:52:35Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 388841 rows in 46748 ms
[2020-12-28T20:52:35Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389558 rows in 47684 ms
[2020-12-28T20:52:36Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389922 rows in 48124 ms
[2020-12-28T20:52:37Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18749999 rows and produced 573 output batches containing 389143 rows in 49278 ms
[2020-12-28T20:52:39Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 388922 rows in 50871 ms
[2020-12-28T20:52:39Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389605 rows in 51220 ms
[2020-12-28T20:52:40Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389294 rows in 51843 ms
+------------+-----------------+----------------+
| l_shipmode | high_line_count | low_line_count |
+------------+-----------------+----------------+
| MAIL       | 623115          | 934713         |
| SHIP       | 622979          | 934534         |
+------------+-----------------+----------------+
Query 12 iteration 0 took 62321.3 ms{code}


was (Author: andygrove):
Batch size 131072:
{code:java}
[2020-12-28T20:46:28Z DEBUG datafusion::physical_plan::hash_join] Built build-side of hash join containing 3115341 rows in 9926 ms
[2020-12-28T20:46:36Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 388922 rows in 7994 ms
[2020-12-28T20:46:36Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389294 rows in 7986 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389558 rows in 8326 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 388841 rows in 8499 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 390056 rows in 8643 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18749999 rows and produced 144 output batches containing 389143 rows in 8711 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389605 rows in 8712 ms
[2020-12-28T20:46:37Z DEBUG datafusion::physical_plan::hash_join] Processed 144 stream-side input batches containing 18750000 rows and produced 144 output batches containing 389922 rows in 8877 ms
+------------+-----------------+----------------+
| l_shipmode | high_line_count | low_line_count |
+------------+-----------------+----------------+
| MAIL       | 623115          | 934713         |
| SHIP       | 622979          | 934534         |
+------------+-----------------+----------------+
Query 12 iteration 0 took 19559.0 ms
 {code}
Batch size 32768:
{code:java}
 [2020-12-28T20:51:47Z DEBUG datafusion::physical_plan::hash_join] Built build-side of hash join containing 3115341 rows in 9442 ms
[2020-12-28T20:52:33Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 390056 rows in 45356 ms
[2020-12-28T20:52:35Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 388841 rows in 46748 ms
[2020-12-28T20:52:35Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389558 rows in 47684 ms
[2020-12-28T20:52:36Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389922 rows in 48124 ms
[2020-12-28T20:52:37Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18749999 rows and produced 573 output batches containing 389143 rows in 49278 ms
[2020-12-28T20:52:39Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 388922 rows in 50871 ms
[2020-12-28T20:52:39Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389605 rows in 51220 ms
[2020-12-28T20:52:40Z DEBUG datafusion::physical_plan::hash_join] Processed 573 probe-side input batches containing 18750000 rows and produced 573 output batches containing 389294 rows in 51843 ms{code}

> [Rust] [DataFusion] TPC-H q12 does not finish with SF=100 Parquet input and small batch size
> --------------------------------------------------------------------------------------------
>
>                 Key: ARROW-11030
>                 URL: https://issues.apache.org/jira/browse/ARROW-11030
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Rust - DataFusion
>            Reporter: Andy Grove
>            Assignee: Andy Grove
>            Priority: Major
>             Fix For: 3.0.0
>
>
> TPC-H q12 does not finish with SF=100 Parquet input.
> Either I have something wrong with my local setup or there is a major performance regression. I will investigate more after the holidays.
> It is also possible that I am getting confused about which queries and scale factors were working well for me before. We really need to start tracking benchmark results somewhere.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)