You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/02/16 13:00:42 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #39796: [SPARK-39800][SQL][WIP] DataSourceV2: View Support
MaxGekk commented on code in PR #39796:
URL: https://github.com/apache/spark/pull/39796#discussion_r1108407743
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -2369,7 +2369,7 @@ class DataSourceV2SQLSuiteV1Filter
}
}
- test("View commands are not supported in v2 catalogs") {
+ ignore("View commands are not supported in v2 catalogs") {
Review Comment:
Could you remove the test if you supported all those commands.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowCreateViewExec.scala:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.V2ViewDescription
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.execution.LeafExecNode
+
+/**
+ * Physical plan node for showing view create statement.
+ */
+case class ShowCreateViewExec(output: Seq[Attribute], desc: V2ViewDescription)
+ extends V2CommandExec with LeafExecNode {
+
+ override protected def run(): Seq[InternalRow] = {
+ val schema = desc.schema.map(_.name).mkString("(", ", ", ")")
+ val create = s"CREATE VIEW ${desc.identifier} $schema AS\n${desc.query}\n"
Review Comment:
Just in case, shouldn't `${desc.identifier}` be quoted?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DropViewExec.scala:
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.analysis.NoSuchViewException
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.{Identifier, ViewCatalog}
+
+/**
+ * Physical plan node for dropping a view.
+ */
+case class DropViewExec(
+ catalog: ViewCatalog,
+ ident: Identifier,
+ ifExists: Boolean) extends LeafV2CommandExec {
+
+ override protected def run(): Seq[InternalRow] = {
+ val exists = try {
+ catalog.viewExists(ident)
Review Comment:
`viewExists()` doesn't throw the `NoSuchViewException` exception. Even the default implementation catches it and returns a boolean, see
https://github.com/apache/spark/blob/d12abff7e83705fb0e187a79f86b45f99e4b7abb/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ViewCatalog.java#L108-L114
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterViewExec.scala:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.SparkException
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.{Identifier, ViewCatalog, ViewChange}
+
+/**
+ * Physical plan node for altering a view.
+ */
+case class AlterViewExec(
+ catalog: ViewCatalog,
+ ident: Identifier,
+ changes: Seq[ViewChange]) extends LeafV2CommandExec {
+
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ catalog.alterView(ident, changes: _*)
+ } catch {
+ case e: IllegalArgumentException =>
+ throw new SparkException(s"Invalid view change: ${e.getMessage}", e)
Review Comment:
Please, introduce an error class in `error-classes.json` if such class doesn't exist.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterViewExec.scala:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.SparkException
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.{Identifier, ViewCatalog, ViewChange}
+
+/**
+ * Physical plan node for altering a view.
+ */
+case class AlterViewExec(
+ catalog: ViewCatalog,
+ ident: Identifier,
+ changes: Seq[ViewChange]) extends LeafV2CommandExec {
+
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ catalog.alterView(ident, changes: _*)
+ } catch {
+ case e: IllegalArgumentException =>
+ throw new SparkException(s"Invalid view change: ${e.getMessage}", e)
+ case e: UnsupportedOperationException =>
+ throw new SparkException(s"Unsupported view change: ${e.getMessage}", e)
Review Comment:
the same, please, use an error class.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AlterViewExec.scala:
##########
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources.v2
+
+import org.apache.spark.SparkException
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.{Identifier, ViewCatalog, ViewChange}
+
+/**
+ * Physical plan node for altering a view.
+ */
+case class AlterViewExec(
+ catalog: ViewCatalog,
+ ident: Identifier,
+ changes: Seq[ViewChange]) extends LeafV2CommandExec {
+
+ override protected def run(): Seq[InternalRow] = {
+ try {
+ catalog.alterView(ident, changes: _*)
+ } catch {
+ case e: IllegalArgumentException =>
+ throw new SparkException(s"Invalid view change: ${e.getMessage}", e)
+ case e: UnsupportedOperationException =>
Review Comment:
`alterView` doesn't throw `UnsupportedOperationException` but throws `NoSuchViewException`. Could you adjust the comment of `alterView` according to status quo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org