You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@spamassassin.apache.org by Dave Pooser <da...@pooserville.com> on 2014/06/17 22:22:01 UTC

Re: Consecutive Newlines in Rawbody Rules (was: Re: Bayes refinement)

On 5/22/14 6:48 PM, "Karsten Bräckelmann" <gu...@rudersport.de> wrote:

>On Thu, 2014-05-22 at 18:34 -0500, David B Funk wrote:
>> After doing some experimenting with that code I came up with something
>>that
>> I'd argue is more semantically correct:
>> 
>>      # if we've got a long series of blank lines, limit them
>>      if (defined $start) {
>>        my $max_blank_lines = 20;
>>        my $num = $start-$cnt;
>>        if ($num > $max_blank_lines) {
>>          splice @message, $cnt+2, $num-$max_blank_lines;
>>        }
>>        undef $start;
>>      }
>> 
>> IE limit a message to no more than "$max_blank_lines" in a row, not the
>>total
>> collapse of more than 11. (adjust $max_blank_lines as you see fit or
>>make it
>> a configurable parameter).
>
>+1
>
>Can you file a bug report or raise the topic in dev@ list? The code
>change is sufficiently simple, but I want that issue discussed first.
>Wonder what's the reason for that collapsing in the first place.

Did any decision on this get reached? I'm tired enough of that particular
flavor of spam that I'm considering making David's modifications locally
to Message.pm -- but obviously I'd prefer to leave the core modules
unmolested if there's an "official" fix in the works.
-- 
Dave Pooser
Cat-Herder-in-Chief, Pooserville.com
"...Life is not a journey to the grave with the intention of arriving
safely in one pretty and well-preserved piece, but to slide across the
finish line broadside, thoroughly used up, worn out, leaking oil, and
shouting GERONIMO!!!" -- Bill McKenna





Re: Consecutive Newlines in Rawbody Rules

Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 6/17/2014 4:53 PM, Dave Pooser wrote:
> On 6/17/14 3:31 PM, "Kevin A. McGrail" <KM...@PCCC.com> wrote:
>
>> On 6/17/2014 4:22 PM, Dave Pooser wrote:
>>> Did any decision on this get reached?
>>>
>> Yes, I believe it was committed to trunk and considered resolved.
> Presumably that will be released in 3.4.1 -- is there a target date for
> that release?
Hi Dave,

I was planning for a 4/30 release in keeping with our release goals 
until the zones box failed.  So there is no release date planned.

However, here are my priorities in order for the project (which are 
subject to change and others could decide they want to do things 
differently, etc):

- Get the zones replacement box work and rule updates publishing again
- Get zones backup working and make sure cron is in svn
- Make sure bug 7056 goes out for Spamhaus in rule updates ok.
- Get the new TLDs into RegistrarBoundaries
- Get TxRep polished enough so it can stay in 3.4.1
- Implement some RBL changes I want to test
- Announce the new logo formally and update the logo on the website 
missing the trademark symbol
- Bug 7003 - README updates

Then there are some bugs I think should get fixed with 3.4.1 but could 
slip if needed.

- Bug 7006 - sa-update version oddity
- Bug 7012 - sa-update exit
- Bug 6995 - specify user for fall back
- Bug 7010 - RuleQA hash output
- Bug 7042 - Hard Code sa-compile path
- Bug 7047 - Sorted by score for summary
- Bug 7046 - Spamc randomization
- Bug 6961 - Font test bug

All the other blockers: 6751, 3082, 3908, 6934 and 6352 should be pushed 
to 3.4.2.

So Ivo, Tamer and Philip, nows a good time to start pushing towards CLAs 
and getting stuff into SVN and ready for consideration on 3.4.1.

- release 3.4.1
- Get SOUGHT backup and running with people like Alex and Daniel able to 
access the boxes
- See if we can fix things like bug 6400
- Get Freebsd working for builds bug 6887

- release 3.4.X or 3.5.0
For the next release after that, I've got some big ideas like the Domain 
Age distributed network system as well as my URIBL work (#44488). 
Hopefully will talk to a board rep about doing that under ASF sooner 
than later! Plus more mundane things like DMARC support. And some even 
crazier ideas ;-)

Regards,
KAM

Re: Consecutive Newlines in Rawbody Rules

Posted by Dave Pooser <da...@pooserville.com>.
On 6/17/14 3:31 PM, "Kevin A. McGrail" <KM...@PCCC.com> wrote:

>On 6/17/2014 4:22 PM, Dave Pooser wrote:
>> Did any decision on this get reached?
>>
>Yes, I believe it was committed to trunk and considered resolved.

Presumably that will be released in 3.4.1 -- is there a target date for
that release?
-- 
Dave Pooser
Cat-Herder-in-Chief, Pooserville.com
"...Life is not a journey to the grave with the intention of arriving
safely in one pretty and well-preserved piece, but to slide across the
finish line broadside, thoroughly used up, worn out, leaking oil, and
shouting GERONIMO!!!" -- Bill McKenna





Re: Consecutive Newlines in Rawbody Rules

Posted by "Kevin A. McGrail" <KM...@PCCC.com>.
On 6/17/2014 4:22 PM, Dave Pooser wrote:
> Did any decision on this get reached? I'm tired enough of that 
> particular flavor of spam that I'm considering making David's 
> modifications locally to Message.pm -- but obviously I'd prefer to 
> leave the core modules unmolested if there's an "official" fix in the 
> works. 
Yes, I believe it was committed to trunk and considered resolved.

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=3712
http://svn.apache.org/viewvc?view=revision&revision=1600260

Regards,
KAM