You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "SteveYurongSu (via GitHub)" <gi...@apache.org> on 2024/11/21 08:17:42 UTC
[PR] [To dev/1.3] Pipe: Reduce the memory usage & Enable insertNode memory control for stream mode degrade and stuck restart (#14102) [iotdb]
SteveYurongSu opened a new pull request, #14161:
URL: https://github.com/apache/iotdb/pull/14161
Co-authored-by: Steve Yurong Su <ro...@apache.org>
(cherry picked from commit 3cb544e)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3] Pipe: Reduce the memory usage & Enable insertNode memory control for stream mode degrade and stuck restart (#14102) [iotdb]
Posted by "SteveYurongSu (via GitHub)" <gi...@apache.org>.
SteveYurongSu merged PR #14161:
URL: https://github.com/apache/iotdb/pull/14161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3] Pipe: Reduce the memory usage & Enable insertNode memory control for stream mode degrade and stuck restart (#14102) [iotdb]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #14161:
URL: https://github.com/apache/iotdb/pull/14161#issuecomment-2490364090
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14161) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=14161&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=14161&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=14161&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14161&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=14161&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=14161)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [To dev/1.3] Pipe: Reduce the memory usage & Enable insertNode memory control for stream mode degrade and stuck restart (#14102) [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #14161:
URL: https://github.com/apache/iotdb/pull/14161#issuecomment-2490446904
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/14161?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `35.65217%` with `148 lines` in your changes missing coverage. Please review.
> Project coverage is 41.19%. Comparing base [(`ad41c55`)](https://app.codecov.io/gh/apache/iotdb/commit/ad41c5518b1b7b19b34c1803c3d0fc4a56794a04?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2b53767`)](https://app.codecov.io/gh/apache/iotdb/commit/2b53767313df7acd5eb104ef6641ed5f6192ec99?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on dev/1.3.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/14161?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...pipe/agent/task/meta/PipeTemporaryMetaInAgent.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Fagent%2Ftask%2Fmeta%2FPipeTemporaryMetaInAgent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9hZ2VudC90YXNrL21ldGEvUGlwZVRlbXBvcmFyeU1ldGFJbkFnZW50LmphdmE=) | 0.00% | [29 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...otdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fpipe%2Fagent%2Ftask%2FPipeDataNodeTaskAgent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcGlwZS9hZ2VudC90YXNrL1BpcGVEYXRhTm9kZVRhc2tBZ2VudC5qYXZh) | 0.00% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...gent/task/meta/PipeTemporaryMetaInCoordinator.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Fagent%2Ftask%2Fmeta%2FPipeTemporaryMetaInCoordinator.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9hZ2VudC90YXNrL21ldGEvUGlwZVRlbXBvcmFyeU1ldGFJbkNvb3JkaW5hdG9yLmphdmE=) | 46.15% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mmons/consensus/index/impl/StateProgressIndex.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fconsensus%2Findex%2Fimpl%2FStateProgressIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvY29uc2Vuc3VzL2luZGV4L2ltcGwvU3RhdGVQcm9ncmVzc0luZGV4LmphdmE=) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ensus/index/impl/TimeWindowStateProgressIndex.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fconsensus%2Findex%2Fimpl%2FTimeWindowStateProgressIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvY29uc2Vuc3VzL2luZGV4L2ltcGwvVGltZVdpbmRvd1N0YXRlUHJvZ3Jlc3NJbmRleC5qYXZh) | 26.66% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../metric/PipeTemporaryMetaInCoordinatorMetrics.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fpipe%2Fmetric%2FPipeTemporaryMetaInCoordinatorMetrics.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvcGlwZS9tZXRyaWMvUGlwZVRlbXBvcmFyeU1ldGFJbkNvb3JkaW5hdG9yTWV0cmljcy5qYXZh) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ol/thrift/impl/DataNodeInternalRPCServiceImpl.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fdatanode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fdb%2Fprotocol%2Fthrift%2Fimpl%2FDataNodeInternalRPCServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9kYXRhbm9kZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW90ZGIvZGIvcHJvdG9jb2wvdGhyaWZ0L2ltcGwvRGF0YU5vZGVJbnRlcm5hbFJQQ1NlcnZpY2VJbXBsLmphdmE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/iotdb/commons/pipe/agent/task/PipeTaskAgent.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fpipe%2Fagent%2Ftask%2FPipeTaskAgent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvcGlwZS9hZ2VudC90YXNrL1BpcGVUYXNrQWdlbnQuamF2YQ==) | 68.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/iotdb/confignode/persistence/pipe/PipeInfo.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fpersistence%2Fpipe%2FPipeInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL3BlcnNpc3RlbmNlL3BpcGUvUGlwZUluZm8uamF2YQ==) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ons/consensus/index/impl/RecoverProgressIndex.java](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&filepath=iotdb-core%2Fnode-commons%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcommons%2Fconsensus%2Findex%2Fimpl%2FRecoverProgressIndex.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9ub2RlLWNvbW1vbnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2lvdGRiL2NvbW1vbnMvY29uc2Vuc3VzL2luZGV4L2ltcGwvUmVjb3ZlclByb2dyZXNzSW5kZXguamF2YQ==) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [17 more](https://app.codecov.io/gh/apache/iotdb/pull/14161?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev/1.3 #14161 +/- ##
=============================================
- Coverage 41.22% 41.19% -0.04%
Complexity 71 71
=============================================
Files 3469 3470 +1
Lines 222086 222234 +148
Branches 26383 26399 +16
=============================================
- Hits 91562 91548 -14
- Misses 130524 130686 +162
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/iotdb/pull/14161?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
----
🚨 Try these New Features:
- [Flaky Tests Detection](https://docs.codecov.com/docs/test-result-ingestion-beta) - Detect and resolve failed and flaky tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org