[jira] [Comment Edited] (HDFS-13736) BlockPlacementPolicyDefault can not choose favored nodes when 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false

["Ayush Saxena (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920108#comment-16920108 ] 

Ayush Saxena edited comment on HDFS-13736 at 8/31/19 3:58 PM:
--------------------------------------------------------------

Thanx [~xiaodong.hu] for the report,

Can we just, add a parameter to {{chooseLocalStorage}} to denote it needs to check favored node and change the condition to something like this :

{code:java}
 if ((preferLocalNode || isFavoredNode) && localMachine instanceof DatanodeDescriptor
        && clusterMap.contains(localMachine))
{code}

* We even need to extend a test to check the behavior.


was (Author: ayushtkn):
Thanx [~xiaodong.hu] for the report,
Seems the patch doesn't apply now.

Anyway can we just, add a parameter to {{chooseLocalStorage}} to denote it needs to check favored node and change the condition to something like this :

{code:java}
 if ((preferLocalNode || isFavoredNode) && localMachine instanceof DatanodeDescriptor
        && clusterMap.contains(localMachine))
{code}

* We even need to extend a test to check the behavior.

> BlockPlacementPolicyDefault can not choose favored nodes when 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-13736
>                 URL: https://issues.apache.org/jira/browse/HDFS-13736
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.2.0
>            Reporter: hu xiaodong
>            Assignee: hu xiaodong
>            Priority: Major
>         Attachments: HDFS-13736.001.patch
>
>
> BlockPlacementPolicyDefault can not choose favored nodes when 'dfs.namenode.block-placement-policy.default.prefer-local-node' set to false.  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org