You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/07 08:54:21 UTC

[GitHub] [shardingsphere] taojintianxia opened a new pull request, #20857: Refactor : add nightly trigger for transaction IT

taojintianxia opened a new pull request, #20857:
URL: https://github.com/apache/shardingsphere/pull/20857

     * add nightly trigger for transaction IT.
     * improve the nightly builds process. 
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #20857: Refactor : add nightly trigger for transaction IT

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #20857:
URL: https://github.com/apache/shardingsphere/pull/20857#discussion_r964587260


##########
.github/workflows/it-transaction.yml:
##########
@@ -42,6 +42,8 @@ on:
       - 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/**'
       - 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/**'
       - '!*.md'
+  schedule:
+    - cron: '0 21 */1 * *'  # once a day. UTC time

Review Comment:
   it's not like the tests in scaling, this should be executed nightly even in forked repository.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] sandynz commented on a diff in pull request #20857: Refactor : add nightly trigger for transaction IT

Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #20857:
URL: https://github.com/apache/shardingsphere/pull/20857#discussion_r964577603


##########
.github/workflows/it-transaction.yml:
##########
@@ -42,6 +42,8 @@ on:
       - 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/**'
       - 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/**'
       - '!*.md'
+  schedule:
+    - cron: '0 21 */1 * *'  # once a day. UTC time

Review Comment:
   Suggest to add `if: (github.event_name == 'schedule' && github.repository == 'apache/shardingsphere')` to avoid it's triggered in forked project



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #20857: Refactor : add nightly trigger for transaction IT

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #20857:
URL: https://github.com/apache/shardingsphere/pull/20857#discussion_r964587461


##########
.github/workflows/it-transaction.yml:
##########
@@ -42,6 +42,8 @@ on:
       - 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-env/**'
       - 'shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/**'
       - '!*.md'
+  schedule:
+    - cron: '0 21 */1 * *'  # once a day. UTC time

Review Comment:
   > Suggest to add `if: (github.event_name == 'schedule' && github.repository == 'apache/shardingsphere')` to avoid it's triggered in forked project
   
   it's not like the tests in scaling, this should be executed nightly even in forked repository.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] taojintianxia closed pull request #20857: Refactor : add nightly trigger for transaction IT

Posted by GitBox <gi...@apache.org>.
taojintianxia closed pull request #20857: Refactor : add nightly trigger for transaction IT
URL: https://github.com/apache/shardingsphere/pull/20857


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org