You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Michael McCandless (Jira)" <ji...@apache.org> on 2022/05/29 17:45:00 UTC

[jira] [Comment Edited] (LUCENE-10596) Remove unused parameter in #getOrAddPerField

    [ https://issues.apache.org/jira/browse/LUCENE-10596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17543691#comment-17543691 ] 

Michael McCandless edited comment on LUCENE-10596 at 5/29/22 5:44 PM:
----------------------------------------------------------------------

Thanks for noticing this!  +1 to remove it if indeed it is a pointless method)!

 


was (Author: mikemccand):
Thanks for noticing this!!  +1 to remove it if indeed it is a pointless method!!

 

> Remove unused parameter in #getOrAddPerField
> --------------------------------------------
>
>                 Key: LUCENE-10596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10596
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 9.2
>            Reporter: tangdh
>            Priority: Minor
>
> I noticed that the parameter fieldType is no longer used in the method getOrAddPerField(indexingChain.java:773), do we need to remove it? If so, I'd be happy to raise a PR



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org