You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/07/08 13:00:59 UTC
[GitHub] [incubator-pegasus] shenxingwuying opened a new pull request, #1042: chore(build) remove some cpp files auto generated by thrift #1040
shenxingwuying opened a new pull request, #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042
Need not save the files generated by thrift in the repo
issue: https://github.com/apache/incubator-pegasus/issues/1040
### What problem does this PR solve? <!--add issue link with summary if exists-->
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1042: chore(build): remove some cpp files auto generated by thrift
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042#discussion_r917228629
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -409,3 +409,13 @@ ExternalProject_Add(http-parser
INSTALL_COMMAND cp -R http_parser.h ${TP_OUTPUT}/include/nodejs/http_parser.h
BUILD_IN_SOURCE 1
)
+
+# ExternalProject_Add(python
+# URL ${OSS_URL_PREFIX}/Python-2.7.18.tgz
+# https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
Review Comment:
python has been installed on each Dockerfile, no need to install it again. See
https://github.com/apache/incubator-pegasus/blob/master/docker/pegasus-build-env/centos7/Dockerfile#L28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1042: chore(build): remove some cpp files auto generated by thrift
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042#discussion_r917228629
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -409,3 +409,13 @@ ExternalProject_Add(http-parser
INSTALL_COMMAND cp -R http_parser.h ${TP_OUTPUT}/include/nodejs/http_parser.h
BUILD_IN_SOURCE 1
)
+
+# ExternalProject_Add(python
+# URL ${OSS_URL_PREFIX}/Python-2.7.18.tgz
+# https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
Review Comment:
python has been installed on each Dockerfile, no need to installed again. See
https://github.com/apache/incubator-pegasus/blob/master/docker/pegasus-build-env/centos7/Dockerfile#L28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1042: chore(build): remove the auto-generated cpp code by thrift compiler
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042#issuecomment-1182661851
please rebase the latest master branch to resolve conflicts, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1042: chore(build) remove some cpp files auto generated by thrift #1040
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042#discussion_r917228629
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -409,3 +409,13 @@ ExternalProject_Add(http-parser
INSTALL_COMMAND cp -R http_parser.h ${TP_OUTPUT}/include/nodejs/http_parser.h
BUILD_IN_SOURCE 1
)
+
+# ExternalProject_Add(python
+# URL ${OSS_URL_PREFIX}/Python-2.7.18.tgz
+# https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
Review Comment:
python3 is installed on each Dockerfile, no need to installed again. See
https://github.com/apache/incubator-pegasus/blob/master/docker/pegasus-build-env/centos7/Dockerfile#L28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] shenxingwuying commented on a diff in pull request #1042: chore(build): remove the auto-generated cpp code by thrift compiler
Posted by GitBox <gi...@apache.org>.
shenxingwuying commented on code in PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042#discussion_r919187948
##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -409,3 +409,13 @@ ExternalProject_Add(http-parser
INSTALL_COMMAND cp -R http_parser.h ${TP_OUTPUT}/include/nodejs/http_parser.h
BUILD_IN_SOURCE 1
)
+
+# ExternalProject_Add(python
+# URL ${OSS_URL_PREFIX}/Python-2.7.18.tgz
+# https://www.python.org/ftp/python/2.7.18/Python-2.7.18.tgz
Review Comment:
python3 . ok .
I'll try again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1042: chore(build): remove the auto-generated cpp code by thrift compiler
Posted by GitBox <gi...@apache.org>.
acelyc111 merged PR #1042:
URL: https://github.com/apache/incubator-pegasus/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org