You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/05/29 20:53:49 UTC

[Impala-ASF-CR] WIP: bump thrift to 0.23.0 for impala-shell

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24382


Change subject: WIP: bump thrift to 0.23.0 for impala-shell
......................................................................

WIP: bump thrift to 0.23.0 for impala-shell

Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
---
M shell/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24382/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24382

to look at the new patch set (#4).

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................

IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell

Bumping to 0.23.0 fixed THRIFT-792 and allowed inspecting actual
socket errors. This revealed that the negative tests for non-http
hs2 tests with verify_cert did not fail due to server verification
- instead verification was not even tried.
See https://github.com/cloudera/impyla/pull/609 for more details.
This patch fixes verify_cert with binary connections and updates
SSL tests to expect the correct error. impyla dependency is also
bumped to get the fix above.

The generated Python files are not regenerated. There
were no compiler changes between 0.22.0 and 0.23.0.

Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
---
M infra/python/deps/requirements.txt
M shell/impala_shell/impala_client.py
M shell/requirements.txt
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_ipv6.py
5 files changed, 31 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24382/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24382

to look at the new patch set (#5).

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................

IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell

Bumping to 0.23.0 fixed THRIFT-792 and allowed inspecting actual
socket errors. This revealed that the negative tests for non-http
hs2 tests with verify_cert did not fail due to server verification
- instead verification was not even tried.
See https://github.com/cloudera/impyla/pull/609 for more details.
This patch fixes verify_cert with binary connections and updates
SSL tests to expect the correct error. impyla dependency is also
bumped to get the fix above.

The generated Python files are not regenerated. There
were no compiler changes between 0.22.0 and 0.23.0.

Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
---
M infra/python/deps/requirements.txt
M shell/impala_shell/impala_client.py
M shell/requirements.txt
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_ipv6.py
5 files changed, 34 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24382/5
-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] WIP: bump thrift to 0.23.0 for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: WIP: bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13554/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 20:54:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24382/4/infra/python/deps/requirements.txt
File infra/python/deps/requirements.txt:

http://gerrit.cloudera.org:8080/#/c/24382/4/infra/python/deps/requirements.txt@a34
PS4, Line 34: 
From the build failures, it looks like hdfs still requires six.



-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:45:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 4:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24382/4/shell/impala_shell/impala_client.py
File shell/impala_shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/24382/4/shell/impala_shell/impala_client.py@123
PS4, Line 123: def get_ssl_context(ca_cert, verify_cert):
flake8: E302 expected 2 blank lines, found 1



-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:20:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > I'd filed https://issues.apache.org/jira/browse/IMPALA-14558 for
>  > this bump with some notes about new fixes.
> 
> Thanks for the ticket!
> Do you think that there are cases where the change should lead to better error messages in impala-shell so tests could be updated?

The tests in https://gerrit.cloudera.org/c/23519/ mention THRIFT-792 and could be updated.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:26:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jun 2026 18:21:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: bump thrift to 0.23.0 for impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: WIP: bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 1:

I'd filed https://issues.apache.org/jira/browse/IMPALA-14558 for this bump with some notes about new fixes.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 16:23:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24382/4/shell/impala_shell/impala_client.py
File shell/impala_shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/24382/4/shell/impala_shell/impala_client.py@123
PS4, Line 123: def get_ssl_context(ca_cert, verify_cert):
> flake8: E302 expected 2 blank lines, found 1
Please fix this.



-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:24:29 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13569/


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:28:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24382

to look at the new patch set (#2).

Change subject: IMPALA-14558: Bump thrift to 0.23.0 for impala-shell
......................................................................

IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Bump to 0.23.0 to get a few fixes. The goal is to also
bump to 0.23.0 in impyla to allow compatible Thrift
dependency in the two projects.

The generated Python files are not regenerated. There
were no compiler changes between 0.22.0 and 0.23.0.

Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
---
M shell/requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24382/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22692/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:28:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13574/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jun 2026 08:04:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: bump thrift to 0.23.0 for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: WIP: bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 30 May 2026 01:27:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: bump thrift to 0.23.0 for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: WIP: bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22665/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 21:05:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2026 05:48:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22678/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:40:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22712/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jun 2026 07:49:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24382/4/shell/impala_shell/impala_client.py
File shell/impala_shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/24382/4/shell/impala_shell/impala_client.py@123
PS4, Line 123: 
> Please fix this.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jun 2026 15:29:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jun 2026 12:28:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24382

to look at the new patch set (#3).

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................

IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell

Bumping to 0.23.0 fixed THRIFT-792 and allowed inspecting actual
socket errors. This revealed that the negative tests for non-http
hs2 tests with verify_cert did not fail due to server verification
- instead verification was not even tried.
See https://github.com/cloudera/impyla/pull/609 for more details.
This patch fixes verify_cert with binary connections and updates
SSL tests to expect the correct error. impyla dependency is also
bumped to get the fix above.

The generated Python files are not regenerated. There
were no compiler changes between 0.22.0 and 0.23.0.

Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
---
M infra/python/deps/requirements.txt
M shell/impala_shell/impala_client.py
M shell/requirements.txt
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_ipv6.py
5 files changed, 31 insertions(+), 37 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/24382/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13569/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:16:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 3:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24382/3/shell/impala_shell/impala_client.py
File shell/impala_shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/24382/3/shell/impala_shell/impala_client.py@123
PS3, Line 123: def get_ssl_context(ca_cert, verify_cert):
flake8: E302 expected 2 blank lines, found 1



-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:16:06 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................


Patch Set 3:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22691/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2026 17:24:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 2:

> I'd filed https://issues.apache.org/jira/browse/IMPALA-14558 for
 > this bump with some notes about new fixes.

Thanks for the ticket!
Do you think that there are cases where the change should lead to better error messages in impala-shell so tests could be updated?


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:22:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Bump thrift to 0.23.0 for impala-shell

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Bump thrift to 0.23.0 for impala-shell
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 18:22:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14558: Fix verify cert=True and bump thrift to 0.23.0 in impala-shell

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24382 )

Change subject: IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell
......................................................................

IMPALA-14558: Fix verify_cert=True and bump thrift to 0.23.0 in impala-shell

Bumping to 0.23.0 fixed THRIFT-792 and allowed inspecting actual
socket errors. This revealed that the negative tests for non-http
hs2 tests with verify_cert did not fail due to server verification
- instead verification was not even tried.
See https://github.com/cloudera/impyla/pull/609 for more details.
This patch fixes verify_cert with binary connections and updates
SSL tests to expect the correct error. impyla dependency is also
bumped to get the fix above.

The generated Python files are not regenerated. There
were no compiler changes between 0.22.0 and 0.23.0.

Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Reviewed-on: http://gerrit.cloudera.org:8080/24382
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M infra/python/deps/requirements.txt
M shell/impala_shell/impala_client.py
M shell/requirements.txt
M tests/custom_cluster/test_client_ssl.py
M tests/custom_cluster/test_ipv6.py
5 files changed, 34 insertions(+), 37 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Michael Smith: Looks good to me, but someone else must approve
  Joe McDonnell: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24382
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife2f72421ff59da77c059de5dae3371dc9fa2f29
Gerrit-Change-Number: 24382
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>