You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/08/30 20:58:01 UTC

Re: Review Request 70335: Sent framework info to agents when applying operations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70335/
-----------------------------------------------------------

(Updated Aug. 30, 2019, 8:58 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, Chun-Hung Hsiao, Gastón Kleiman, Joseph Wu, and Meng Zhu.


Summary (updated)
-----------------

Sent framework info to agents when applying operations.


Bugs: MESOS-8582
    https://issues.apache.org/jira/browse/MESOS-8582


Repository: mesos


Description
-------

This patch updates the master to send a framework's full
`FrameworkInfo` to the agent in the `ApplyOperationMessage`.
The agent is updated to checkpoint frameworks when applying
operations, and to unschedule GC on the meta directory when
a new framework is created.

The test `TerminalOrphanOperationAfterMasterFailover` is
removed since this patch eliminates the case of orphan
operations relevant to that test.


Diffs (updated)
-----

  src/master/master.cpp f00906ef2d33920f23127a74ed141fff9d32865b 
  src/messages/messages.proto f5ea0381bd89a5f7b8c28b624da29055e1751f6a 
  src/slave/slave.hpp 77b5bc0082c6bb73fbd48a2ebe812629921645cb 
  src/slave/slave.cpp 4e9365669395c89202961ca80d41cd92346d23d2 
  src/tests/reservation_tests.cpp cd84cd24d3587fafc01ae1861f22c47262f2d7e9 


Diff: https://reviews.apache.org/r/70335/diff/2/

Changes: https://reviews.apache.org/r/70335/diff/1-2/


Testing
-------

`make check`


Thanks,

Greg Mann