[GitHub] [airflow] potiuk commented on a change in pull request #6761: [AIRFLOW-6204] Add GCP system tests helper

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6761: [AIRFLOW-6204] Add GCP system tests helper
URL: https://github.com/apache/airflow/pull/6761#discussion_r362319567
 
 

 ##########
 File path: tests/gcp/operators/test_cloud_memorystore_system.py
 ##########
 @@ -18,31 +18,35 @@
 # under the License.
 """System tests for Google Cloud Memorystore operators"""
 
-from tests.gcp.operators.test_cloud_memorystore_system_helper import GCPCloudMemorystoreTestHelper
+import pytest
+
+from airflow.gcp.example_dags.example_cloud_memorystore import BUCKET_NAME
 from tests.gcp.utils.gcp_authenticator import GCP_MEMORYSTORE  # TODO: Update it
-from tests.test_utils.gcp_system_helpers import GCP_DAG_FOLDER, provide_gcp_context, skip_gcp_system
-from tests.test_utils.system_tests_class import SystemTest
+from tests.test_utils.gcp_system_helpers import GCP_DAG_FOLDER, GcpSystemTest, provide_gcp_context
+
+command = GcpSystemTest.commands_registry()
+
+
+@command
+def create_bucket():
+    GcpSystemTest.create_gcs_bucket(BUCKET_NAME, location="europe-north1")
 
 
-@skip_gcp_system(GCP_MEMORYSTORE, require_local_executor=True)
-class CloudBuildExampleDagsSystemTest(SystemTest):
-    """
-    System tests for Google Cloud Memorystore operators
+@command
+def delete_bucket():
+    GcpSystemTest.delete_gcs_bucket(BUCKET_NAME)
 
-    It use a real service.
-    """
-    helper = GCPCloudMemorystoreTestHelper()
 
-    @provide_gcp_context(GCP_MEMORYSTORE)
-    def setUp(self):
-        super().setUp()
-        self.helper.create_bucket()
+@pytest.fixture
+def helper():
+    create_bucket()
+    yield
+    delete_bucket()
 
-    @provide_gcp_context(GCP_MEMORYSTORE)
-    def test_run_example_dag(self):
-        self.run_dag('gcp_cloud_memorystore', GCP_DAG_FOLDER)
 
-    @provide_gcp_context(GCP_MEMORYSTORE)
-    def tearDown(self):
-        self.helper.delete_bucket()
-        super().tearDown()
+@command
+@GcpSystemTest.skip(GCP_MEMORYSTORE)
+@pytest.mark.usefixtures("helper")
+def test_run_example_dag():
 
 Review comment:
   Why wait for 1.10.x? We already moved to pytest in 1.10 as well (I cherry-picked all the changes there and 1.10.7 already uses pytest). 
   
   We also updated 1.10.7 documentation with information that we use pytest and that we should (for example) prefer standard python asserts which are overwritten by pytest. 
   
   I don't think abandoning 1.10 line has anything to do with pytest. 
   
   We already as community agreed to go pytest-first (there was vote about it). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services