[GitHub] [superset] villebro commented on issue #15638: [native filters] Numerical range initial default value should be accepted as filled one

[GitBox <gi...@apache.org>]

villebro commented on issue #15638:
URL: https://github.com/apache/superset/issues/15638#issuecomment-892500289


   > @villebro I remember I talked to you about this behavior and you mentioned it was a design decision when implementing the plugin. Can you post what was the reasoning so we can check if it needs to change?
   
   The motivation for leaving the edge values as undefined filters is as follows:
   - We need a way to leave the filter undefined similar to how can be done in all other native filters
   - By making the edge values emit filters that include both the lower and upper bound, we add filters to the query object that don't change the result but will cause a cache miss (=a filter clause that is always true).
   
   I agree that the current design isn't optimal - however, in the absence of an alternative mechanism for leaving 1) the lower bound 2) the upper bound or 3) both bounds undefined, I think this is the best solution for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org