[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5501: GEODE-8339: Redis Rename hangs when servers are killed and revived

[GitBox <gi...@apache.org>]

sabbeyPivotal commented on a change in pull request #5501:
URL: https://github.com/apache/geode/pull/5501#discussion_r486463800



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
##########
@@ -611,7 +611,8 @@ PartitionedRegionRedundancyTracker getRedundancyTracker() {
     return redundancyTracker;
   }
 
-  public void computeWithPrimaryLocked(Object key, Runnable r) throws PrimaryBucketLockException {
+  public boolean computeWithPrimaryLocked(Object key, Runnable r, boolean tryLock)

Review comment:
       You are correct, Darrel, we no longer need it.  Jens and I talked about it a bit this. morning and thought it might be beneficial to have the option in the method, but since it's not needed for this PR it probably makes sense to remove it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org