You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by jo...@apache.org on 2006/09/28 09:14:13 UTC
svn commit: r450727 -
/lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java
Author: josias
Date: Thu Sep 28 00:14:12 2006
New Revision: 450727
URL: http://svn.apache.org/viewvc?view=rev&rev=450727
Log:
changed date format from rfc1123 to iso8601 for standard compliance reasons. if somebody needs rfc1223 format, please use the DateConverterModule.
Modified:
lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java
Modified: lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java?view=diff&rev=450727&r1=450726&r2=450727
==============================================================================
--- lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java (original)
+++ lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java Thu Sep 28 00:14:12 2006
@@ -191,13 +191,13 @@
}
/**
- * Returns last modification date in HTTP date format (see RFC 1123).
+ * Returns last modification date in ISO-8601 format.
* @param document
* @return Formatted HTTP date string.
* @throws ConfigurationException
*/
protected String getLastModified(Document document) throws ConfigurationException {
- SimpleDateFormat httpDateFormat = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss z");
+ SimpleDateFormat httpDateFormat = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss Z");
return httpDateFormat.format(document.getLastModified());
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org
Re: svn commit: r450727 - /lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java
Posted by Joern Nettingsmeier <po...@uni-due.de>.
Josias Thöny wrote:
> On Thu, 2006-09-28 at 09:37 +0200, Jörn Nettingsmeier wrote:
>> josias@apache.org wrote:
>>> Author: josias
>>> Date: Thu Sep 28 00:14:12 2006
>>> New Revision: 450727
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=450727
>>> Log:
>>> changed date format from rfc1123 to iso8601 for standard compliance reasons. if somebody needs rfc1223 format, please use the DateConverterModule.
>> i haven't had time to look at it, but won't this be a problem for cache
>> expiration dates? iirc this date format is used in some http headers. i
>> may be wrong though.
>
> I didn't find any occurrences of doc-info:lastModified in the lenya
> sitemaps. Please use the date-converter module if you use this value
> somewhere for an http header.
you are right. it's just that i've had cache expiration issues a while
ago, and your commit rang a bell....
--
"I don't need backups. I need restore!" - Trad.
--
Jörn Nettingsmeier, EDV-Administrator
Institut für Politikwissenschaft
Universität Duisburg-Essen, Standort Duisburg
Mail: pol-admin@uni-due.de, Telefon: 0203/379-2736
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: svn commit: r450727 -
/lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java
Posted by Josias Thöny <jo...@wyona.com>.
On Thu, 2006-09-28 at 09:37 +0200, Jörn Nettingsmeier wrote:
> josias@apache.org wrote:
> > Author: josias
> > Date: Thu Sep 28 00:14:12 2006
> > New Revision: 450727
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=450727
> > Log:
> > changed date format from rfc1123 to iso8601 for standard compliance reasons. if somebody needs rfc1223 format, please use the DateConverterModule.
>
> i haven't had time to look at it, but won't this be a problem for cache
> expiration dates? iirc this date format is used in some http headers. i
> may be wrong though.
I didn't find any occurrences of doc-info:lastModified in the lenya
sitemaps. Please use the date-converter module if you use this value
somewhere for an http header.
BTW, The page-envelope:lastModified returns the iso date also, so it
should be more consistent now.
Further, I changed the format of the doc-info:expires date also, and
updated the sitemap of the default pub accordingly. Please update your
sitemap, too.
Sorry for the inconvenience.
Josias
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: svn commit: r450727 - /lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/DocumentInfoModule.java
Posted by Jörn Nettingsmeier <po...@uni-duisburg-essen.de>.
josias@apache.org wrote:
> Author: josias
> Date: Thu Sep 28 00:14:12 2006
> New Revision: 450727
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=450727
> Log:
> changed date format from rfc1123 to iso8601 for standard compliance reasons. if somebody needs rfc1223 format, please use the DateConverterModule.
i haven't had time to look at it, but won't this be a problem for cache
expiration dates? iirc this date format is used in some http headers. i
may be wrong though.
--
"Open source takes the bullshit out of software."
- Charles Ferguson on TechnologyReview.com
--
Jörn Nettingsmeier, EDV-Administrator
Institut für Politikwissenschaft
Universität Duisburg-Essen, Standort Duisburg
Mail: pol-admin@uni-due.de, Telefon: 0203/379-2736
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org