[jira] [Commented] (FLINK-2720) Add Storm-CountMetric in flink-stormcompatibility

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896228#comment-15896228 ] 

ASF GitHub Bot commented on FLINK-2720:
---------------------------------------

Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1157#discussion_r104311065
  
    --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyContext.java ---
    @@ -120,7 +129,19 @@ public ReducedMetric registerMetric(final String name, final IReducer combiner,
     	@SuppressWarnings("unchecked")
     	@Override
     	public IMetric registerMetric(final String name, final IMetric metric, final int timeBucketSizeInSecs) {
    -		throw new UnsupportedOperationException("Metrics are not supported by Flink");
    +
    +		// TODO: There is no use for timeBucketSizeInSecs yet.
    +		if (metric instanceof FlinkCountMetric) {
    --- End diff --
    
    Here it looks user need to change code to make metrics work


> Add Storm-CountMetric in flink-stormcompatibility
> -------------------------------------------------
>
>                 Key: FLINK-2720
>                 URL: https://issues.apache.org/jira/browse/FLINK-2720
>             Project: Flink
>          Issue Type: New Feature
>          Components: Storm Compatibility
>            Reporter: Huang Wei
>            Assignee: Matthias J. Sax
>             Fix For: 1.0.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Add the CountMetric for the first step of storm metrics:
> 1.Do a wrapper FlinkCountMetric for CountMetric
> 2.push the RuntimeContext in FlinkTopologyContext to use `addAccumulator` method for registering the metric.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)