[Impala-ASF-CR] IMPALA-12493: Allow retry after failed cancel query

["Quanlong Huang (Code Review)" <ge...@cloudera.org>]

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20584 )

Change subject: IMPALA-12493: Allow retry after failed cancel_query
......................................................................


Patch Set 4:

(2 comments)

Good to see lots of codes are simplified!

http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/client-request-state.cc@229
PS4, Line 229:   RETURN_IF_CANCELLED(this);
Does this fix another issue? If so, it'd be nice if we have test coverage for this.


http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/impala-server.cc
File be/src/service/impala-server.cc:

http://gerrit.cloudera.org:8080/#/c/20584/4/be/src/service/impala-server.cc@a1753
PS4, Line 1753: 
Is it correct to skip this inflight check?



-- 
To view, visit http://gerrit.cloudera.org:8080/20584
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2c8872e91a7ff078cedb13e0771bcfaae6ee24
Gerrit-Change-Number: 20584
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 12:56:08 +0000
Gerrit-HasComments: Yes