You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/02 11:58:42 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #7189: ARROW-8795: [C++] Limited iOS support

pitrou commented on a change in pull request #7189:
URL: https://github.com/apache/arrow/pull/7189#discussion_r433820499



##########
File path: cpp/src/arrow/CMakeLists.txt
##########
@@ -189,6 +189,7 @@ set(ARROW_SRCS
     util/utf8.cc
     util/value_parsing.cc
     vendored/base64.cpp
+    vendored/datetime/ios.mm

Review comment:
       Shouldn't this file only be compiled on iOS targets? At least it seems it doesn't compile properly on our CI builds.

##########
File path: cpp/CMakeLists.txt
##########
@@ -340,6 +340,11 @@ if(ARROW_ORC)
   set(ARROW_WITH_ZSTD ON)
 endif()
 
+# datetime code used by iOS requries zlib support

Review comment:
       Typo: "requires"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org