RE: strange change to src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java

[Mark Roberts <ma...@cs.washington.edu>]

I really would like to move forward with this.  If you look at the code in
src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java you will see:

Public addAttribute ...
Protected addAnnotationEntry ...
Public removeAttribute ...
Protected removeAnnotationEntry ...
Public removeAttributes ...
Protected remove AnnotationEntries ...

I would just like to change the protected to public so one can manipulate
annotations in the same manner as attributes.

Thank you,
Mark

-----Original Message-----
From: Gary Gregory [mailto:garydgregory@gmail.com]
Sent: Friday, October 18, 2019 8:29 AM
To: Commons Developers List
Subject: Re: strange change to
src/main/java/org/apache/bcel/generic/FieldGenOrMethodGen.java

Hi All:

The upshot here (to me) is that we have an opportunity to help Mark by:

- Simply agreeing that it is OK to change the visibility of the method(s) if
appropriate tests are added, or:
- Provide a new API _somewhere_, presumably in the _best/right_ place that
fulfills his app's needs.

The difference being changing visibility solely for expediency's sake vs.
thinking about the API and making sure provide this functionality in the
right place.

It seems that Mark can help us see it best since he's quite familiar with
the code by now.

Gary

On Fri, Oct 18, 2019 at 5:37 AM Emmanuel Bourg <eb...@apache.org> wrote:

> Le 18/10/2019 à 11:10, Xeno Amess a écrit :
> > Do commons follow semver?
>
> No but we care about backward compatibility.
>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org