You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "sergeyuttsel (via GitHub)" <gi...@apache.org> on 2023/06/21 14:10:59 UTC

[GitHub] [ignite-3] sergeyuttsel opened a new pull request, #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

sergeyuttsel opened a new pull request, #2232:
URL: https://github.com/apache/ignite-3/pull/2232

   https://issues.apache.org/jira/browse/IGNITE-19735


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] sergeyuttsel closed pull request #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

Posted by "sergeyuttsel (via GitHub)" <gi...@apache.org>.
sergeyuttsel closed pull request #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage
URL: https://github.com/apache/ignite-3/pull/2232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2232: IGNITE-19735 Created interface for interaction with local KeyValueStorage of the meta storage

Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2232:
URL: https://github.com/apache/ignite-3/pull/2232#discussion_r1239510362


##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java:
##########
@@ -181,4 +181,11 @@ public interface MetaStorageManager extends IgniteComponent {
      * @return Cluster time.
      */
     ClusterTime clusterTime();
+
+    /**
+     * Returns the local meta storage.
+     *
+     * @return Storage.
+     */
+    LocalMetaStorageManager getLocalStorage();

Review Comment:
   This seems to go against the Dependency Injection principle. Why can't local metastorage manager be an independent component/service that gets injected (via constructor) to each component that needs it (including the MetaStorageManager)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org