You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/09 20:16:15 UTC
[GitHub] [flink] rkhachatryan opened a new pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
rkhachatryan opened a new pull request #18694:
URL: https://github.com/apache/flink/pull/18694
## What is the purpose of the change
```
PriorityQueue elements with equal priority can be polled in different order
before and after recovery. This may result in e.g. timers
being removed or not being fired
This change address this by recording poll as remove which is based on equals.
```
## Verifying this change
`ProcessingTimeWindowCheckpointingITCase`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034595589
Thanks for the review!
I'll merge the PR after resolving the (unrelated) build failures (FLINK-26065).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26fbdb1397fdfa82c12b50a3754f578824494205 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063)
* 91cf27f1a40e1e6e616c89440707027eb601c69b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26fbdb1397fdfa82c12b50a3754f578824494205 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063)
* 91cf27f1a40e1e6e616c89440707027eb601c69b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26fbdb1397fdfa82c12b50a3754f578824494205 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91cf27f1a40e1e6e616c89440707027eb601c69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "1e2841dc58a10b066a41d08661dadc876d74b373",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1e2841dc58a10b066a41d08661dadc876d74b373",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26fbdb1397fdfa82c12b50a3754f578824494205 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063)
* 1e2841dc58a10b066a41d08661dadc876d74b373 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1035572360
Build failures are unrelated (FLINK-26036, FLINK-24288).
Build from private branch [succeeded](https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=1382&view=results).
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034156693
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 26fbdb1397fdfa82c12b50a3754f578824494205 (Wed Feb 09 20:19:20 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26fbdb1397fdfa82c12b50a3754f578824494205 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063)
* 91cf27f1a40e1e6e616c89440707027eb601c69b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 26fbdb1397fdfa82c12b50a3754f578824494205 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
}, {
"hash" : "7d30f95525f934e440c834cd032ca06cfabf98a7",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31138",
"triggerID" : "7d30f95525f934e440c834cd032ca06cfabf98a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7d30f95525f934e440c834cd032ca06cfabf98a7 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31138)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan merged pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
rkhachatryan merged pull request #18694:
URL: https://github.com/apache/flink/pull/18694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
}, {
"hash" : "7d30f95525f934e440c834cd032ca06cfabf98a7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31138",
"triggerID" : "7d30f95525f934e440c834cd032ca06cfabf98a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91cf27f1a40e1e6e616c89440707027eb601c69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065)
* 7d30f95525f934e440c834cd032ca06cfabf98a7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31138)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18694: [FLINK-26062][state/changelog] Replace poll() with remove() for PQ states
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18694:
URL: https://github.com/apache/flink/pull/18694#issuecomment-1034158633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31063",
"triggerID" : "26fbdb1397fdfa82c12b50a3754f578824494205",
"triggerType" : "PUSH"
}, {
"hash" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065",
"triggerID" : "91cf27f1a40e1e6e616c89440707027eb601c69b",
"triggerType" : "PUSH"
}, {
"hash" : "7d30f95525f934e440c834cd032ca06cfabf98a7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7d30f95525f934e440c834cd032ca06cfabf98a7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91cf27f1a40e1e6e616c89440707027eb601c69b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31065)
* 7d30f95525f934e440c834cd032ca06cfabf98a7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org