You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2013/12/07 23:28:48 UTC

Review Request 16105: Refactoring patch to remove unnecessary methods in FileSink and other cleanup

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16105/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-5982
    https://issues.apache.org/jira/browse/HIVE-5982


Repository: hive


Description
-------

Refactoring patch to remove unnecessary methods in FileSink and other cleanup


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1548974 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1548974 

Diff: https://reviews.apache.org/r/16105/diff/


Testing
-------

No new functionality. Existing test case suffice.


Thanks,

Ashutosh Chauhan


Re: Review Request 16105: Refactoring patch to remove unnecessary methods in FileSink and other cleanup

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16105/#review30054
-----------------------------------------------------------

Ship it!


Ship It!

- Thejas Nair


On Dec. 7, 2013, 10:28 p.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16105/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2013, 10:28 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5982
>     https://issues.apache.org/jira/browse/HIVE-5982
> 
> 
> Repository: hive
> 
> 
> Description
> -------
> 
> Refactoring patch to remove unnecessary methods in FileSink and other cleanup
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java 1548974 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1548974 
> 
> Diff: https://reviews.apache.org/r/16105/diff/
> 
> 
> Testing
> -------
> 
> No new functionality. Existing test case suffice.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>