[PATCH] Convert path to local style when rising BAD_RELATIVE_PATH error from diff.

[Timofey Zhakov <ti...@chemodax.net>]

Hi,

I found a little bug in the svn_client_diff7() function: If the
function returns an error 'the path must be an immediate child of the
directory', Subversion formats it with the paths in internal style.

The error cannot be reproduced via the command line client, but exists
in the API. I found it when playing with diff in PoshSvn.

[[[
Convert path to local style when rising BAD_RELATIVE_PATH error from diff.

* subversion\libsvn_client\diff.c
  (adjust_paths_for_diff_labels): Invoke svn_dirent_local_style() function
  when making BAD_RELATIVE_PATH error to create the error with correct paths.
]]]

Thanks!

-- 
Timofei Zhakov

Re: [PATCH] Convert path to local style when rising BAD_RELATIVE_PATH error from diff.

[Nathan Hartman <ha...@gmail.com>]

On Thu, May 23, 2024 at 2:48 PM Timofey Zhakov <ti...@chemodax.net> wrote:
>
> Hi,
>
> I found a little bug in the svn_client_diff7() function: If the
> function returns an error 'the path must be an immediate child of the
> directory', Subversion formats it with the paths in internal style.
>
> The error cannot be reproduced via the command line client, but exists
> in the API. I found it when playing with diff in PoshSvn.
>
> [[[
> Convert path to local style when rising BAD_RELATIVE_PATH error from diff.
>
> * subversion\libsvn_client\diff.c
>   (adjust_paths_for_diff_labels): Invoke svn_dirent_local_style() function
>   when making BAD_RELATIVE_PATH error to create the error with correct paths.
> ]]]
>
> Thanks!
>
> --
> Timofei Zhakov


Committed in r1917946.
Nominated for backport to 1.14.x in r1917947.

Thanks again!

Nathan