You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by anilkumar gingade <ag...@pivotal.io> on 2015/10/02 01:34:27 UTC
Re: Review Request 36993: GEODE-146: Queries are not thread safe due
to scopeId variable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36993/#review101291
-----------------------------------------------------------
Ship it!
Ship It!
- anilkumar gingade
On July 31, 2015, 5:14 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36993/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 5:14 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, Lynn Gallinat, and Qihong Chen.
>
>
> Bugs: GEODE-146
> https://issues.apache.org/jira/browse/GEODE-146
>
>
> Repository: geode
>
>
> Description
> -------
>
> Currently queries are not thread safe although they should be. This is due to the way the scopeId is stored in the CompiledSelect. The fix consists of storing the scopeId in the execution context.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/CompiledSelect.java 0b07211
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/QueryJUnitTest.java 5490278
>
> Diff: https://reviews.apache.org/r/36993/diff/
>
>
> Testing
> -------
>
> build with failures in hdfs dunit tests. There were some other test failures not related to query. Will try to rerun tests and see if those clear up.
>
>
> Thanks,
>
> Jason Huynh
>
>