You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/02/22 18:15:48 UTC
[GitHub] [geode] nabarunnag commented on a change in pull request #6008: GEODE-8918: fix replication in multisite systems
nabarunnag commented on a change in pull request #6008:
URL: https://github.com/apache/geode/pull/6008#discussion_r580466562
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java
##########
@@ -741,8 +741,8 @@ public boolean isPdxTypesRegion() {
// This is for all regions except pdx Region
if (!isPdxTypesRegion) {
// Make sure we are distributing to only those senders whose id
- // is available on this region
- if (allGatewaySenderIds.contains(sender.getId())) {
+ // is available on this region and whose state is running
+ if (allGatewaySenderIds.contains(sender.getId()) && sender.isRunning()) {
Review comment:
can we use the new method hasRunningGatewaySender
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegion.java
##########
@@ -741,8 +741,8 @@ public boolean isPdxTypesRegion() {
// This is for all regions except pdx Region
if (!isPdxTypesRegion) {
// Make sure we are distributing to only those senders whose id
- // is available on this region
- if (allGatewaySenderIds.contains(sender.getId())) {
+ // is available on this region and whose state is running
+ if (allGatewaySenderIds.contains(sender.getId()) && sender.isRunning()) {
allRemoteDSIds.add(sender.getRemoteDSId());
}
} else { // this else is for PDX region
Review comment:
Do we also need a check if sender is running for PDX region
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org