You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/10 20:52:23 UTC
[GitHub] [airflow] michaelmicheal opened a new pull request, #27605: scheduler_job, add metric for scheduler loop timer
michaelmicheal opened a new pull request, #27605:
URL: https://github.com/apache/airflow/pull/27605
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
For better visibility into scheduler behaviour, this PR adds a metric with the scheduler loop duration. We've patched this into our deployment of Airflow to identify and resolve performance issues with the query finding "running" dag_runs.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27605: scheduler_job, add metric for scheduler loop timer
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27605:
URL: https://github.com/apache/airflow/pull/27605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #27605: scheduler_job, add metric for scheduler loop timer
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #27605:
URL: https://github.com/apache/airflow/pull/27605#discussion_r1022052169
##########
docs/apache-airflow/logging-monitoring/metrics.rst:
##########
@@ -161,6 +161,7 @@ Name Description
start date and the actual DagRun start date
``scheduler.critical_section_duration`` Milliseconds spent in the critical section of scheduler loop --
only a single scheduler can enter this loop at a time
+``scheduler.scheduler_loop_duration`` Milliseconds spent running one scheduler loop
Review Comment:
```suggestion
``scheduler.scheduler_loop_duration`` Milliseconds spent running one scheduler loop
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] michaelmicheal commented on pull request #27605: scheduler_job, add metric for scheduler loop timer
Posted by GitBox <gi...@apache.org>.
michaelmicheal commented on PR #27605:
URL: https://github.com/apache/airflow/pull/27605#issuecomment-1315363575
@uranusjr @potiuk Good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org