[GitHub] spark pull request: [SPARK-3086] [SPARK-3043] [SPARK-3156] [mllib]...

[jkbradley <gi...@git.apache.org>]

Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2125#discussion_r17017226
  
    --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/impl/DecisionTreeMetadata.scala ---
    @@ -26,14 +26,15 @@ import org.apache.spark.mllib.tree.configuration.Strategy
     import org.apache.spark.mllib.tree.impurity.Impurity
     import org.apache.spark.rdd.RDD
     
    -
     /**
      * Learning and dataset metadata for DecisionTree.
      *
      * @param numClasses    For classification: labels can take values {0, ..., numClasses - 1}.
      *                      For regression: fixed at 0 (no meaning).
    + * @param maxBins  Maximum number of bins, for all features.
      * @param featureArity  Map: categorical feature index --> arity.
      *                      I.e., the feature takes values in {0, ..., arity - 1}.
    --- End diff --
    
    This actually does match the parameter meaning.  The parameter is set when DecisionTreeMetadata is constructed by buildMetadata, and it is set to be the actual max, not the max possible/allowed number of bins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org