You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "PaddyMelody (via GitHub)" <gi...@apache.org> on 2023/04/27 05:36:01 UTC
[GitHub] [hudi] PaddyMelody opened a new pull request, #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
PaddyMelody opened a new pull request, #8585:
URL: https://github.com/apache/hudi/pull/8585
…actTableFileSystemView
### Change Logs
This PR improved org.apache.hudi.common.table.view.AbstractTableFileSystemView header comments
### Impact
Add the br tag to make it easier for users to understand
### Risk level (write none, low medium or high below)
none
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1525604467
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef0b65c6471448ba86899c587618e60a6377d3c8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [HUDI-8585]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1524750802
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef0b65c6471448ba86899c587618e60a6377d3c8 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [HUDI-8585]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1524843651
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef0b65c6471448ba86899c587618e60a6377d3c8 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1534181338
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
}, {
"hash" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16816",
"triggerID" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef0b65c6471448ba86899c587618e60a6377d3c8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700)
* 00d8808aa98094c0b8ba49fc216d87fdf8fee893 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16816)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] PaddyMelody commented on a diff in pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "PaddyMelody (via GitHub)" <gi...@apache.org>.
PaddyMelody commented on code in PR #8585:
URL: https://github.com/apache/hudi/pull/8585#discussion_r1184684061
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -73,11 +73,15 @@
import static org.apache.hudi.common.table.timeline.HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS;
/**
- * Common thread-safe implementation for multiple TableFileSystemView Implementations. <br>Provides uniform handling of: <br>(a)
- * Loading file-system views from underlying file-system <br>(b) Pending compaction operations and changing file-system
- * views based on that <br>(c) Thread-safety in loading and managing file system views for this table. <br>(d) resetting
- * file-system views <br>The actual mechanism of fetching file slices from different view storages is delegated to
- * sub-classes.
+ * Common thread-safe implementation for multiple TableFileSystemView Implementations.
+ * Provides uniform handling of:
+ * <ul>
+ * <li>Loading file-system views from underlying file-system</li>
+ * <li>Pending compaction operations and changing file-system views based on that</li>
+ * <li>Thread-safety in loading and managing file system views for this table</li>
Review Comment:
done, thanks for your guidance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [MINOR] Improve documentation of org.apache.hudi.common.table.view.AbstractTableFileSystemView
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1534351153
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
}, {
"hash" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16816",
"triggerID" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"triggerType" : "PUSH"
}, {
"hash" : "ae183f791a3f548b999abe1b7ab989f8da099c82",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16822",
"triggerID" : "ae183f791a3f548b999abe1b7ab989f8da099c82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00d8808aa98094c0b8ba49fc216d87fdf8fee893 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16816)
* ae183f791a3f548b999abe1b7ab989f8da099c82 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16822)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1534142843
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
}, {
"hash" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ef0b65c6471448ba86899c587618e60a6377d3c8 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700)
* 00d8808aa98094c0b8ba49fc216d87fdf8fee893 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8585:
URL: https://github.com/apache/hudi/pull/8585#discussion_r1181472930
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -73,10 +73,10 @@
import static org.apache.hudi.common.table.timeline.HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS;
/**
- * Common thread-safe implementation for multiple TableFileSystemView Implementations. Provides uniform handling of (a)
- * Loading file-system views from underlying file-system (b) Pending compaction operations and changing file-system
- * views based on that (c) Thread-safety in loading and managing file system views for this table. (d) resetting
- * file-system views The actual mechanism of fetching file slices from different view storages is delegated to
+ * Common thread-safe implementation for multiple TableFileSystemView Implementations. <br>Provides uniform handling of: <br>(a)
+ * Loading file-system views from underlying file-system <br>(b) Pending compaction operations and changing file-system
Review Comment:
Maybe a `<ul>` list makes more sense here? The structure is:
```java
<ul>
<li></li>
<li></li>
...
</ul>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8585: [MINOR] Improve documentation of org.apache.hudi.common.table.view.AbstractTableFileSystemView
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1534730690
> this kind of docs update does not require CI. will just merge it.
Should be caution with the checkstyle error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8585: [MINOR] Improve documentation of org.apache.hudi.common.table.view.AbstractTableFileSystemView
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1534338835
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16700",
"triggerID" : "ef0b65c6471448ba86899c587618e60a6377d3c8",
"triggerType" : "PUSH"
}, {
"hash" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16816",
"triggerID" : "00d8808aa98094c0b8ba49fc216d87fdf8fee893",
"triggerType" : "PUSH"
}, {
"hash" : "ae183f791a3f548b999abe1b7ab989f8da099c82",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae183f791a3f548b999abe1b7ab989f8da099c82",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 00d8808aa98094c0b8ba49fc216d87fdf8fee893 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16816)
* ae183f791a3f548b999abe1b7ab989f8da099c82 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] PaddyMelody commented on a diff in pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "PaddyMelody (via GitHub)" <gi...@apache.org>.
PaddyMelody commented on code in PR #8585:
URL: https://github.com/apache/hudi/pull/8585#discussion_r1184574011
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -73,10 +73,10 @@
import static org.apache.hudi.common.table.timeline.HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS;
/**
- * Common thread-safe implementation for multiple TableFileSystemView Implementations. Provides uniform handling of (a)
- * Loading file-system views from underlying file-system (b) Pending compaction operations and changing file-system
- * views based on that (c) Thread-safety in loading and managing file system views for this table. (d) resetting
- * file-system views The actual mechanism of fetching file slices from different view storages is delegated to
+ * Common thread-safe implementation for multiple TableFileSystemView Implementations. <br>Provides uniform handling of: <br>(a)
+ * Loading file-system views from underlying file-system <br>(b) Pending compaction operations and changing file-system
Review Comment:
That's true. I made some changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8585: [DOC]Improve documentation of org.apache.hudi.common.table.view.Abstr…
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8585:
URL: https://github.com/apache/hudi/pull/8585#discussion_r1184654279
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -73,11 +73,15 @@
import static org.apache.hudi.common.table.timeline.HoodieTimeline.METADATA_BOOTSTRAP_INSTANT_TS;
/**
- * Common thread-safe implementation for multiple TableFileSystemView Implementations. <br>Provides uniform handling of: <br>(a)
- * Loading file-system views from underlying file-system <br>(b) Pending compaction operations and changing file-system
- * views based on that <br>(c) Thread-safety in loading and managing file system views for this table. <br>(d) resetting
- * file-system views <br>The actual mechanism of fetching file slices from different view storages is delegated to
- * sub-classes.
+ * Common thread-safe implementation for multiple TableFileSystemView Implementations.
+ * Provides uniform handling of:
+ * <ul>
+ * <li>Loading file-system views from underlying file-system</li>
+ * <li>Pending compaction operations and changing file-system views based on that</li>
+ * <li>Thread-safety in loading and managing file system views for this table</li>
Review Comment:
For each of the item, end it with `;`, and for the last item, end with `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #8585: [MINOR] Improve documentation of org.apache.hudi.common.table.view.AbstractTableFileSystemView
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on PR #8585:
URL: https://github.com/apache/hudi/pull/8585#issuecomment-1534375447
this kind of docs update does not require CI. will just merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #8585: [MINOR] Improve documentation of org.apache.hudi.common.table.view.AbstractTableFileSystemView
Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #8585:
URL: https://github.com/apache/hudi/pull/8585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org