You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brian Fox (JIRA)" <ji...@codehaus.org> on 2007/03/15 02:22:33 UTC
[jira] Created: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
versionrange doesn't handle singluar version correctly (tests and patch already in svn)
---------------------------------------------------------------------------------------
Key: MNG-2876
URL: http://jira.codehaus.org/browse/MNG-2876
Project: Maven 2
Issue Type: Bug
Components: Artifacts
Affects Versions: 2.0.5, 2.0.4, 2.0.3, 2.0.2
Reporter: Brian Fox
I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2876:
-------------------------------
Fix Version/s: 2.0.6
> versionrange doesn't handle singluar version correctly (tests and patch already in svn)
> ---------------------------------------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assigned To: Jason van Zyl
> Fix For: 2.0.6
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singular
version correctly
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2876:
---------------------------
Summary: versionrange doesn't handle singular version correctly (was: versionrange doesn't handle singluar version correctly (tests and patch already in svn))
> versionrange doesn't handle singular version correctly
> ------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 2.1-alpha-1
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90087 ]
Jason van Zyl commented on MNG-2876:
------------------------------------
Yah, that's good. That test fails off and on for a bunch of us. Still haven't tracked it down. No worries.
> versionrange doesn't handle singluar version correctly (tests and patch already in svn)
> ---------------------------------------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assigned To: Jason van Zyl
> Fix For: 2.0.6
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2876:
---------------------------
Fix Version/s: (was: 2.0.x)
2.1
Updated javadoc in 2.0.7...moving issue for better resolution in 2.1
> versionrange doesn't handle singluar version correctly (tests and patch already in svn)
> ---------------------------------------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assigned To: Brian Fox
> Fix For: 2.1
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_90085 ]
Brian Fox commented on MNG-2876:
--------------------------------
Ran IT tests before and after patch and the results are the same.
Only 1 failure:
0108SnapshotUpdate(testSnapshotLocalMetadataUpdatedOnInstall).. Failure
> versionrange doesn't handle singluar version correctly (tests and patch already in svn)
> ---------------------------------------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assigned To: Jason van Zyl
> Fix For: 2.0.6
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2876:
---------------------------
Assignee: Brian Fox (was: Jason van Zyl)
Fix Version/s: (was: 2.0.6)
2.0.x
Discussed with Kenney via email: http://www.nabble.com/version-range-question-tf3250482s177.html and irc: http://dev.rectang.com/logs/codehaus/%23maven/20070315.html.
The patch as written is currently not going to work. I will take this back and see. I think the most likely resolution is to work around inside my plugin, but I will probably add better comments to the javadoc in versionRange because it's confusing the way it is. Any fix has plenty of potential to break things. Ultimately this needs to be addressed in 2.1
> versionrange doesn't handle singluar version correctly (tests and patch already in svn)
> ---------------------------------------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assigned To: Brian Fox
> Fix For: 2.0.x
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singular
version correctly
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2876:
---------------------------
Affects Version/s: 2.0.10
2.0.6
2.0.7
2.0.8
2.0.9
2.1.0-M1
3.0-alpha-1
> versionrange doesn't handle singular version correctly
> ------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.8, 2.0.9, 2.0.10, 2.1.0-M1, 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 3.x
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singular
version correctly
Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason van Zyl updated MNG-2876:
-------------------------------
Patch Submitted: (was: [Yes])
> versionrange doesn't handle singular version correctly
> ------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 2.1-alpha-1
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-2876) versionrange doesn't handle singluar
version correctly (tests and patch already in svn)
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Fox updated MNG-2876:
---------------------------
Testcase included: yes
Complexity: Novice (was: Intermediate)
Patch attached: Yes
> versionrange doesn't handle singluar version correctly (tests and patch already in svn)
> ---------------------------------------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5
> Reporter: Brian Fox
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MNG-2876) versionrange doesn't handle
singular version correctly
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=90179#action_90179 ]
Brian Fox edited comment on MNG-2876 at 1/26/09 4:02 PM:
---------------------------------------------------------
Discussed with Kenney via email: http://www.nabble.com/version-range-question-tf3250482s177.html and irc: http://irc.rectang.com/logs/codehaus/%23maven/20070315.html
The patch as written is currently not going to work. I will take this back and see. I think the most likely resolution is to work around inside my plugin, but I will probably add better comments to the javadoc in versionRange because it's confusing the way it is. Any fix has plenty of potential to break things. Ultimately this needs to be addressed in 2.1
was (Author: brianfox):
Discussed with Kenney via email: http://www.nabble.com/version-range-question-tf3250482s177.html and irc: http://dev.rectang.com/logs/codehaus/%23maven/20070315.html.
The patch as written is currently not going to work. I will take this back and see. I think the most likely resolution is to work around inside my plugin, but I will probably add better comments to the javadoc in versionRange because it's confusing the way it is. Any fix has plenty of potential to break things. Ultimately this needs to be addressed in 2.1
> versionrange doesn't handle singular version correctly
> ------------------------------------------------------
>
> Key: MNG-2876
> URL: http://jira.codehaus.org/browse/MNG-2876
> Project: Maven 2
> Issue Type: Bug
> Components: Artifacts and Repositories
> Affects Versions: 2.0.2, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.8, 2.0.9, 2.0.10, 2.1.0-M1, 3.0-alpha-1
> Reporter: Brian Fox
> Assignee: Brian Fox
> Fix For: 3.x
>
>
> I'm still having trouble with this. I wrote a sample class to show my problem. The issue is that all the contains calls are correct except that a singular version ie "2.0.5" always returns true. Is this an artifact bug, or am I doing something wrong? According to the javadoc for the method (shown in my original post below) the singular version is allowed as a version range.
> The tests and fix are here: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-artifact-version-range-fix
> I just need someone to take a look and I can apply.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira