You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "kazdy (via GitHub)" <gi...@apache.org> on 2024/10/13 22:20:50 UTC
Re: [PR] fix: trim single quotes for date and string partition filter values [hudi-rs]
kazdy commented on code in PR #170:
URL: https://github.com/apache/hudi-rs/pull/170#discussion_r1798603418
##########
crates/core/src/table/partition.rs:
##########
@@ -265,13 +265,36 @@ impl PartitionFilter {
safe: false,
format_options: Default::default(),
};
+
+ let value = match data_type {
+ DataType::Date32 => Self::trim_single_quotes(value),
+ DataType::Date64 => Self::trim_single_quotes(value),
+ DataType::Utf8 => Self::trim_single_quotes(value),
+ DataType::LargeUtf8 => Self::trim_single_quotes(value),
+ DataType::Utf8View => Self::trim_single_quotes(value),
Review Comment:
time and timestamp types should be included too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org