You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:16:26 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #581: fix clippy warnings
Jimexist opened a new pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#issuecomment-864145455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#discussion_r654185047
##########
File path: datafusion/src/logical_plan/dfschema.rs
##########
@@ -248,12 +248,14 @@ where
}
impl ToDFSchema for Schema {
+ #[allow(clippy::wrong_self_convention)]
Review comment:
maybe it's a better idea to remove https://github.com/apache/arrow-datafusion/pull/581/files#diff-54ef5cfee73dd6cdbd9186bbf5931f4e375ccf002f956d1fe8bf35deafaf56a6R244
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
It was failing either way so this line diff was my attempt to fix it in vain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#issuecomment-864295719
Thanks again @Jimexist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#discussion_r654680215
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
Filed https://github.com/apache/arrow-datafusion/issues/590 to fix code coverage job. Will disable it via this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#discussion_r654552043
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
I don't understand this change. It seems to cause an error in CI, right?: https://github.com/apache/arrow-datafusion/pull/581/checks?check_run_id=2858343109
Maybe we could put the old version of tarpaulin back?
##########
File path: datafusion/src/logical_plan/dfschema.rs
##########
@@ -248,12 +248,14 @@ where
}
impl ToDFSchema for Schema {
+ #[allow(clippy::wrong_self_convention)]
Review comment:
I don't understand the suggestion
##########
File path: .github/workflows/rust.yml
##########
@@ -349,9 +349,7 @@ jobs:
export ARROW_TEST_DATA=$(pwd)/testing/data
export PARQUET_TEST_DATA=$(pwd)/parquet-testing/data
- # 2020-11-15: There is a cargo-tarpaulin regression in 0.17.0
- # see https://github.com/xd009642/tarpaulin/issues/618
- cargo install --version 0.16.0 cargo-tarpaulin
+ cargo install --version 0.18.0-alpha3 cargo-tarpaulin
Review comment:
I see -- in that case it does seem like disabling code coverage until it is fixed is the right thing to do, and we can file an issue to re-enable it once whatever underlying issue is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb edited a comment on pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
alamb edited a comment on pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#issuecomment-864282114
I pushed https://github.com/apache/arrow-datafusion/pull/581/commits/ac7808ba2dea0fde5a1dce280529b71f819e80bc to disable the coverage job. Hopefully the CI checks will then pass and we can get master back to green.
Thank you for the help @Jimexist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #581: fix clippy warnings
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #581:
URL: https://github.com/apache/arrow-datafusion/pull/581#issuecomment-864118650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org