You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/07/02 13:56:34 UTC
[GitHub] [cloudstack] neogismm opened a new pull request, #6524: Oauth2 google idp
neogismm opened a new pull request, #6524:
URL: https://github.com/apache/cloudstack/pull/6524
### Description
This PR is to add functionality for OAuth 2.0 authentication with Google as IDP.
Progress:
- [ x] Create client id/secret from Google API console
- [ x] Create a Util class for the core methods
- [ x] Create a Servlet class that handles redirect URLs for a successful or failed flow
- [ ] Method to check if the user is already logged in
- [ ] Check if the user is a new or existing user (implement checking methods with cloudstack database)
- [ ] Logout method
- [ ] Make changes in UI
NB: Progress milestones to be added/edited as I grow my understanding of the codebase.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ x] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1237168957
UI build: :heavy_multiplication_x:
(SL-JID-2292)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] neogismm commented on a diff in pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
neogismm commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r926855160
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/OAuth2Utils.java:
##########
@@ -0,0 +1,28 @@
+package org.apache.cloudstack.oauth2;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleAuthorizationCodeFlow;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.http.javanet.NetHttpTransport;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.client.util.store.MemoryDataStoreFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+
+public class OAuth2Utils {
Review Comment:
Yes we can do that. AuthorizationCodeFlow class can be used to connect to any oauth server. So it makes sense to keep only the generic methods in the util class. But as of now, I'm keen towards building a minimum viable product with only google as idp. Once it is done, I'll tidy up the Util class to only include methods that can be used by any oauth server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r913312661
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/OAuth2Utils.java:
##########
@@ -0,0 +1,28 @@
+package org.apache.cloudstack.oauth2;
+
+import com.google.api.client.googleapis.auth.oauth2.GoogleAuthorizationCodeFlow;
+import com.google.api.client.http.HttpTransport;
+import com.google.api.client.http.javanet.NetHttpTransport;
+import com.google.api.client.json.jackson2.JacksonFactory;
+import com.google.api.client.util.store.MemoryDataStoreFactory;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.List;
+
+public class OAuth2Utils {
Review Comment:
This class looks very specific to Google, we can rather rename it or let the Google auth be the implementation of an abstract method in the oauth framework
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/LoginServlet.java:
##########
@@ -0,0 +1,30 @@
+package org.apache.cloudstack.oauth2;
Review Comment:
Also here
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/LoginCallbackServlet.java:
##########
@@ -0,0 +1,46 @@
+package org.apache.cloudstack.oauth2;
Review Comment:
Missing header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1237167530
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6524: Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1172903168
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] neogismm closed pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
neogismm closed pull request #6524: [GSOC] Oauth2 google idp
URL: https://github.com/apache/cloudstack/pull/6524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r964474485
##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,112 @@
--;
UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
Review Comment:
sorry @neogismm I do not understand the entire background. Are you saying you included code for other branches in this one? If you base your changes on main that shouldn´t happen. You can clean up your local working branch and force push it to your github branch to clean it up. There is no need for a new PR.
But these schema changes for 4.17 are not wanted, i'd say.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1237167017
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] neogismm commented on a diff in pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
neogismm commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r964505580
##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,112 @@
--;
UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
Review Comment:
Sorry @DaanHoogland but I'm not able to figure out how to clean up this branch so I'm closing this PR and opening a new one that only includes my additions/changes to the OAuth feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1237164232
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r963508664
##########
.github/workflows/codecov.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: Coverage Check
Review Comment:
this file seems out of scope. Is the intention that a third coverage automaton is added to the project or that the bahaviour of the existing bots are somehow adjusted?
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java:
##########
@@ -50,7 +50,7 @@ public class UpdateCfgCmd extends BaseCmd {
@Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required = true, description = "the name of the configuration")
private String cfgName;
- @Parameter(name = ApiConstants.VALUE, type = CommandType.STRING, description = "the value of the configuration", length = 4095)
+ @Parameter(name = ApiConstants.VALUE, type = CommandType.STRING, description = "the value of the configuration", length = 4096)
Review Comment:
makes sense, but have you considdered null-termination issues?
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1309,24 +1363,29 @@ public boolean storageMigration(VirtualMachineProfile vm, Map<Volume, StoragePoo
for (Map.Entry<Volume, StoragePool> entry : volumeToPool.entrySet()) {
Volume volume = entry.getKey();
StoragePool pool = entry.getValue();
+
+ String volumeToString = getVolumeIdentificationInfos(volume);
+ String poolToString = getReflectOnlySelectedFields(pool);
+
if (volume.getState() != Volume.State.Ready) {
- s_logger.debug("volume: " + volume.getId() + " is in " + volume.getState() + " state");
- throw new CloudRuntimeException("volume: " + volume.getId() + " is in " + volume.getState() + " state");
+ String msg = String.format("Volume [%s] is in [%s] state.", volumeToString, volume.getState());
+ s_logger.error(msg);
+ throw new CloudRuntimeException(msg);
}
if (volume.getPoolId() == pool.getId()) {
- s_logger.debug("volume: " + volume.getId() + " is on the same storage pool: " + pool.getId());
+ s_logger.debug(String.format("Volume [%s] already is on the elected storage pool [%s].", volumeToString, poolToString));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Volume [%s] already is on the elected storage pool [%s].", volumeToString, poolToString));
}
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1790,14 +1875,21 @@ private void cleanupVolumeDuringMigrationFailure(Long volumeId, Long destPoolId)
}
VolumeVO volume = _volsDao.findById(volumeId);
+
+ String destPoolToString = getReflectOnlySelectedFields(destPool);
+ String volumeToString = getReflectOnlySelectedFields(volume);
+
if (volume.getState() == Volume.State.Migrating) {
VolumeVO duplicateVol = _volsDao.findByPoolIdName(destPoolId, volume.getName());
+
if (duplicateVol != null) {
- s_logger.debug("Remove volume " + duplicateVol.getId() + " on storage pool " + destPoolId);
+ String duplicateVolToString = getReflectOnlySelectedFields(duplicateVol);
+
+ s_logger.debug(String.format("Removing volume [%s] from storage pool [%s] because it's duplicated.", duplicateVolToString, destPoolToString));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Removing volume [%s] from storage pool [%s] because it's duplicated.", duplicateVolToString, destPoolToString));
}
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1807,8 +1899,11 @@ private void cleanupVolumeDuringMigrationFailure(Long volumeId, Long destPoolId)
private void cleanupVolumeDuringSnapshotFailure(Long volumeId, Long snapshotId) {
_snapshotSrv.cleanupVolumeDuringSnapshotFailure(volumeId, snapshotId);
VolumeVO volume = _volsDao.findById(volumeId);
+
+ String volumeToString = getReflectOnlySelectedFields(volume);
+
if (volume.getState() == Volume.State.Snapshotting) {
- s_logger.debug("change volume state back to Ready: " + volume.getId());
+ s_logger.debug(String.format("Changing volume [%s] state back to Ready.", volumeToString));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Changing volume [%s] state back to Ready.", volumeToString));
}
```
##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,112 @@
--;
UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
Review Comment:
why changes for the DB v 4.17.1 in this PR?
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1554,17 +1629,20 @@ private Pair<VolumeVO, DataStore> recreateVolume(VolumeVO vol, VirtualMachinePro
if (!primaryDataStore.isManaged()) {
templ = tmplFactory.getReadyBypassedTemplateOnPrimaryStore(templateId, destPool.getId(), dest.getHost().getId());
} else {
- s_logger.debug("Direct download template: " + templateId + " on host: " + dest.getHost().getId() + " and copy to the managed storage pool: " + destPool.getId());
+ s_logger.debug(String.format("Directly downloading template [%s] on host [%s] and copying it to the managed storage pool [%s].",
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Directly downloading template [%s] on host [%s] and copying it to the managed storage pool [%s].",
}
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1129,20 +1171,21 @@ public void cleanupVolumes(long vmId) throws ConcurrentOperationException {
@Override
public void doInTransactionWithoutResult(TransactionStatus status) {
for (VolumeVO vol : volumesForVm) {
+ String volumeToString = getReflectOnlySelectedFields(vol);
+
if (vol.getVolumeType().equals(Type.ROOT)) {
// Destroy volume if not already destroyed
boolean volumeAlreadyDestroyed = (vol.getState() == Volume.State.Destroy || vol.getState() == Volume.State.Expunged || vol.getState() == Volume.State.Expunging);
if (!volumeAlreadyDestroyed) {
volService.destroyVolume(vol.getId());
} else {
- s_logger.debug("Skipping destroy for the volume " + vol + " as its in state " + vol.getState().toString());
+ s_logger.debug(String.format("Skipping destroy for the volume [%s] as it is in [%s] state.", volumeToString, vol.getState().toString()));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Skipping destroy for the volume [%s] as it is in [%s] state.", volumeToString, vol.getState().toString()));
}
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1790,14 +1875,21 @@ private void cleanupVolumeDuringMigrationFailure(Long volumeId, Long destPoolId)
}
VolumeVO volume = _volsDao.findById(volumeId);
+
+ String destPoolToString = getReflectOnlySelectedFields(destPool);
+ String volumeToString = getReflectOnlySelectedFields(volume);
+
if (volume.getState() == Volume.State.Migrating) {
VolumeVO duplicateVol = _volsDao.findByPoolIdName(destPoolId, volume.getName());
+
if (duplicateVol != null) {
- s_logger.debug("Remove volume " + duplicateVol.getId() + " on storage pool " + destPoolId);
+ String duplicateVolToString = getReflectOnlySelectedFields(duplicateVol);
+
+ s_logger.debug(String.format("Removing volume [%s] from storage pool [%s] because it's duplicated.", duplicateVolToString, destPoolToString));
_volsDao.remove(duplicateVol.getId());
}
- s_logger.debug("change volume state to ready from migrating in case migration failure for vol: " + volumeId);
+ s_logger.debug(String.format("Changing volume [%s] state from Migrating to Ready in case of migration failure.", volumeToString));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Changing volume [%s] state from Migrating to Ready in case of migration failure.", volumeToString));
}
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1971,18 +2075,20 @@ public DiskProfile importVolume(Type type, String name, DiskOffering offering, L
@Override
public void unmanageVolumes(long vmId) {
if (s_logger.isDebugEnabled()) {
- s_logger.debug("Unmanaging storage for vm: " + vmId);
+ s_logger.debug(String.format("Unmanaging storage for VM [%s].", _userVmDao.findById(vmId)));
}
final List<VolumeVO> volumesForVm = _volsDao.findByInstance(vmId);
Transaction.execute(new TransactionCallbackNoReturn() {
@Override
public void doInTransactionWithoutResult(TransactionStatus status) {
for (VolumeVO vol : volumesForVm) {
+ String volToString = getReflectOnlySelectedFields(vol);
+
boolean volumeAlreadyDestroyed = (vol.getState() == Volume.State.Destroy || vol.getState() == Volume.State.Expunged
|| vol.getState() == Volume.State.Expunging);
if (volumeAlreadyDestroyed) {
- s_logger.debug("Skipping destroy for the volume " + vol + " as its in state " + vol.getState().toString());
+ s_logger.debug(String.format("Skipping Destroy for the volume [%s] as it is in [%s] state.", volToString, vol.getState().toString()));
Review Comment:
```suggestion
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Skipping Destroy for the volume [%s] as it is in [%s] state.", volToString, vol.getState().toString()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] neogismm commented on a diff in pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
neogismm commented on code in PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#discussion_r963849159
##########
engine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql:
##########
@@ -20,4 +20,112 @@
--;
UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'network.disable.rpfilter' AND `value` != 'true';
-UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
\ No newline at end of file
+UPDATE `cloud`.`configuration` SET `value` = 'false' WHERE `name` = 'consoleproxy.disable.rpfilter' AND `value` != 'true';
+
Review Comment:
Rebasing the branch and pushing brings changes from all authors including my own changes.
My changes are reserved for plugins/user-authenticators/oauth2.
I know this is not the right way to push my code, can you suggest how to do it the right way?
Maybe I'll create a new PR with only my changes and close this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6524: [GSOC] Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1172904042
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6524 (SL-JID-1887)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6524: Oauth2 google idp
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6524:
URL: https://github.com/apache/cloudstack/pull/6524#issuecomment-1172902989
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org