You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/07/22 05:47:05 UTC

[echarts] branch master updated: tooltip: fix probably null access (#15399)

This is an automated email from the ASF dual-hosted git repository.

shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git


The following commit(s) were added to refs/heads/master by this push:
     new b63e899  tooltip: fix probably null access (#15399)
b63e899 is described below

commit b63e899507d118ba899a59f8b15b29ea654b3e97
Author: Yi Shen <bm...@gmail.com>
AuthorDate: Thu Jul 22 13:46:55 2021 +0800

    tooltip: fix probably null access (#15399)
---
 src/component/tooltip/TooltipView.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/component/tooltip/TooltipView.ts b/src/component/tooltip/TooltipView.ts
index e18a656..c2688f6 100644
--- a/src/component/tooltip/TooltipView.ts
+++ b/src/component/tooltip/TooltipView.ts
@@ -969,8 +969,10 @@ class TooltipView extends ComponentView {
 
                 // check is cbParams data value changed
                 lastCbParamsList && zrUtil.each(lastItem.seriesDataIndices, (idxItem) => {
-                    const cbParams = cbParamsList[idxItem.seriesIndex];
-                    if (cbParams && lastCbParamsList[idxItem.seriesIndex].data !== cbParams.data) {
+                    const seriesIdx = idxItem.seriesIndex;
+                    const cbParams = cbParamsList[seriesIdx];
+                    const lastCbParams = lastCbParamsList[seriesIdx];
+                    if (cbParams && lastCbParams && lastCbParams.data !== cbParams.data) {
                         contentNotChanged = false;
                     }
                 });

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org