You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/01/24 05:46:48 UTC
[kudu-CR] [scripts] support uint64 t values for hybrid timestamps
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19438
Change subject: [scripts] support uint64_t values for hybrid timestamps
......................................................................
[scripts] support uint64_t values for hybrid timestamps
This patch updates the convert-hybrid-timestamp.py script to support
hybrid timestamp values that are beyond 2^63.
Before this patch:
echo 12039974332919063140 | python convert-hybrid-timestamp.py
1979-04-25 19:18:05.862281 L=33380
After this patch:
$ echo 12039974332919063140 | python convert-hybrid-timestamp.py
2063-02-23 01:00:58.622818 L=612
Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
---
M src/kudu/scripts/convert-hybrid-timestamp.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/19438/1
--
To view, visit http://gerrit.cloudera.org:8080/19438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Gerrit-Change-Number: 19438
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [scripts] support uint64 t values for hybrid timestamps
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19438 )
Change subject: [scripts] support uint64_t values for hybrid timestamps
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Gerrit-Change-Number: 19438
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 25 Jan 2023 03:32:05 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] support uint64 t values for hybrid timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19438 )
Change subject: [scripts] support uint64_t values for hybrid timestamps
......................................................................
Patch Set 2:
Thank you for review!
--
To view, visit http://gerrit.cloudera.org:8080/19438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Gerrit-Change-Number: 19438
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 25 Jan 2023 04:41:46 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] support uint64 t values for hybrid timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [scripts] support uint64_t values for hybrid timestamps
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Gerrit-Change-Number: 19438
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [scripts] support uint64 t values for hybrid timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19438 )
Change subject: [scripts] support uint64_t values for hybrid timestamps
......................................................................
Patch Set 1: Verified+1
unrelated failure in LeaderRebalancerTest.AddTserver (TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/19438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Gerrit-Change-Number: 19438
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 24 Jan 2023 18:10:51 +0000
Gerrit-HasComments: No
[kudu-CR] [scripts] support uint64 t values for hybrid timestamps
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19438 )
Change subject: [scripts] support uint64_t values for hybrid timestamps
......................................................................
[scripts] support uint64_t values for hybrid timestamps
This patch updates the convert-hybrid-timestamp.py script to support
hybrid timestamp values that are beyond 2^63.
Before this patch:
echo 12039974332919063140 | python convert-hybrid-timestamp.py
1979-04-25 19:18:05.862281 L=33380
After this patch:
$ echo 12039974332919063140 | python convert-hybrid-timestamp.py
2063-02-23 01:00:58.622818 L=612
Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Reviewed-on: http://gerrit.cloudera.org:8080/19438
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/scripts/convert-hybrid-timestamp.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89cf685f765cb2f77c50d4224aacbf416bb9af9a
Gerrit-Change-Number: 19438
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>