You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/07 21:52:45 UTC
[GitHub] [airflow] wolfier opened a new pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
wolfier opened a new pull request #18073:
URL: https://github.com/apache/airflow/pull/18073
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #17198
Uses the list_rows function from BigQueryHook to query data.
If there no more rows, job is finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18073:
URL: https://github.com/apache/airflow/pull/18073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18073:
URL: https://github.com/apache/airflow/pull/18073#issuecomment-915120694
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #18073:
URL: https://github.com/apache/airflow/pull/18073#issuecomment-914709800
Good call! I have updated the test and made sure it works locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18073:
URL: https://github.com/apache/airflow/pull/18073#issuecomment-914680463
Can you also update tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18073:
URL: https://github.com/apache/airflow/pull/18073#issuecomment-914730384
@wolfier Static checks are sad 😿
```
tests/providers/google/cloud/transfers/test_bigquery_to_mysql.py:43:17: E126 continuation line over-indented for hanging indent
tests/providers/google/cloud/transfers/test_bigquery_to_mysql.py:48:13: E121 continuation line under-indented for hanging indent
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] wolfier commented on pull request #18073: Fix BigQuery data extraction in BigQueryToMySqlOperator
Posted by GitBox <gi...@apache.org>.
wolfier commented on pull request #18073:
URL: https://github.com/apache/airflow/pull/18073#issuecomment-914748758
My bad! The tests I ran skipped the flake8 test for some reason :( I made sure to run the test for the test file explicitly and it did pass 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org