You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/11/10 07:31:11 UTC

Review Request 27801: CLOUDSTACK-7866: Passing type value to list_hosts method so as to avoid listing SSVM and CPVM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27801/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7866
    https://issues.apache.org/jira/browse/CLOUDSTACK-7866


Repository: cloudstack-git


Description
-------

Adding type="Routing" while listing hosts (to migrate VM to) so as to avoid listing SSVMs and CPVMs.


Diffs
-----

  test/integration/component/maint/test_host_high_availability.py ecc23f7 

Diff: https://reviews.apache.org/r/27801/diff/


Testing
-------

Not tested.


Thanks,

Gaurav Aradhye


Re: Review Request 27801: CLOUDSTACK-7866: Passing type value to list_hosts method so as to avoid listing SSVM and CPVM

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27801/#review60566
-----------------------------------------------------------

Ship it!


b00f144c204bfa4ffa3db73c9d1fc9e86d79015c master
3e00f99c535e318faab4c09ac943fd8540f81d17 4.5

- SrikanteswaraRao Talluri


On Nov. 10, 2014, 10:50 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27801/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 10:50 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7866
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7866
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Changes:
> 
> 1. Adding type="Routing" while listing hosts (to migrate VM to) so as to avoid listing SSVMs and CPVMs.
> 2. Correcting host.hostid to host.id
> 3. Replacing import * with actual module names
> 
> 
> Diffs
> -----
> 
>   test/integration/component/maint/test_host_high_availability.py ecc23f7 
> 
> Diff: https://reviews.apache.org/r/27801/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test VM deployments (Create HA enabled Compute Service Offering and VM) ... SKIP: Skip
> Verify you can not create new VMs on hosts with an ha.tag ... SKIP: Skip
> Verify you can not migrate VMs to hosts with an ha.tag (positive) ... SKIP: Skip
> Verify you can not migrate VMs to hosts with an ha.tag (negative) ... === TestName: test_04_cant_migrate_vm_to_host_with_ha_negative | Status : SUCCESS ===
> ok
> Verify that none of the VMs with HA enabled migrate to an ha tagged host during live migration ... SKIP: Skip
> Verify that none of the VMs without HA enabled migrate to an ha tagged host during live migration ... SKIP: Skip
> 
> ----------------------------------------------------------------------
> Ran 6 tests in 226.880s
> 
> OK (SKIP=5)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 27801: CLOUDSTACK-7866: Passing type value to list_hosts method so as to avoid listing SSVM and CPVM

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27801/
-----------------------------------------------------------

(Updated Nov. 10, 2014, 4:20 p.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7866
    https://issues.apache.org/jira/browse/CLOUDSTACK-7866


Repository: cloudstack-git


Description (updated)
-------

Changes:

1. Adding type="Routing" while listing hosts (to migrate VM to) so as to avoid listing SSVMs and CPVMs.
2. Correcting host.hostid to host.id
3. Replacing import * with actual module names


Diffs (updated)
-----

  test/integration/component/maint/test_host_high_availability.py ecc23f7 

Diff: https://reviews.apache.org/r/27801/diff/


Testing (updated)
-------

Yes.

Log:
Test VM deployments (Create HA enabled Compute Service Offering and VM) ... SKIP: Skip
Verify you can not create new VMs on hosts with an ha.tag ... SKIP: Skip
Verify you can not migrate VMs to hosts with an ha.tag (positive) ... SKIP: Skip
Verify you can not migrate VMs to hosts with an ha.tag (negative) ... === TestName: test_04_cant_migrate_vm_to_host_with_ha_negative | Status : SUCCESS ===
ok
Verify that none of the VMs with HA enabled migrate to an ha tagged host during live migration ... SKIP: Skip
Verify that none of the VMs without HA enabled migrate to an ha tagged host during live migration ... SKIP: Skip

----------------------------------------------------------------------
Ran 6 tests in 226.880s

OK (SKIP=5)


Thanks,

Gaurav Aradhye