[GitHub] [metron] nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures

[GitBox <gi...@apache.org>]

nickwallen commented on a change in pull request #1568: METRON-2324: verify_licenses.sh and list_dependencies.sh don't properly handle maven failures
URL: https://github.com/apache/metron/pull/1568#discussion_r354463316
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -60,6 +60,7 @@ matrix:
 
     - name: Verify Licenses
       script:
+        - time mvn install -T 2C -q -DskipTests=true -Dmaven.javadoc.skip=true -B -V -Dskip.npm
 
 Review comment:
   (1) What does `-Dskip.npm` do?
   
   (2) Why do we need to build before running `verify_licenses.sh`?
   
   (3) Assuming we do need to build, would it make more sense to put the build step in `dev-utilities/build-utils/list_dependencies.sh`?  If I just manually run that script, we should expect it to work also, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services